Replace MockImageResourceClient with MockImageResourceObserver

third_party/WebKit/Source/core/loader/resource/MockImageResourceObserver.h

 // Copyright 2016 The Chromium Authors. All rights reserved.

[yhirano, 2017/01/06 05:32:38]

2017?

[hiroshige, 2017/01/06 20:04:33]

I thought this is a kind of file renaming from MockImageResourceClient.h (the
diffs are large though), so leaving the copyright header.
(I'm not so sure though)

 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-#ifndef MockImageResourceClient_h
-#define MockImageResourceClient_h
+#ifndef MockImageResourceObserver_h
+#define MockImageResourceObserver_h
 
-#include "core/fetch/MockResourceClient.h"
 #include "core/loader/resource/ImageResource.h"
 #include "core/loader/resource/ImageResourceContent.h"
 #include "core/loader/resource/ImageResourceObserver.h"
+#include <memory>
 
 namespace blink {
 
-class MockImageResourceClient final : public MockResourceClient,
-                                      public ImageResourceObserver {
+class MockImageResourceObserver final : public ImageResourceObserver {
  public:
-  explicit MockImageResourceClient(ImageResource*);
-  ~MockImageResourceClient() override;
+  static std::unique_ptr<MockImageResourceObserver> create(
+      ImageResourceContent* content) {
+    return WTF::wrapUnique(new MockImageResourceObserver(content));
+  }
+  ~MockImageResourceObserver() override;
 
-  void imageNotifyFinished(ImageResourceContent*) override;
-  void imageChanged(ImageResourceContent*, const IntRect*) override;
-
-  String debugName() const override { return "MockImageResourceClient"; }
-
-  bool notifyFinishedCalled() const override;
-
-  void removeAsClient() override;
-  void dispose() override;
+  void removeAsObserver();

[yhirano, 2017/01/06 05:32:39]

I'd prefer stopObserving or something, but it's optional.

[hiroshige, 2017/01/06 20:04:33]

I'll keep this to keep correspondence with removeObserver().

 
   int imageChangedCount() const { return m_imageChangedCount; }
-  int imageNotifyFinishedCount() const { return m_imageNotifyFinishedCount; }
+  bool imageNotifyFinishedCalled() const;
 
-  size_t encodedSizeOnLastImageChanged() const {
-    return m_encodedSizeOnLastImageChanged;
+  int imageWidthOnLastImageChanged() const {
+    return m_imageWidthOnLastImageChanged;
   }
-  size_t encodedSizeOnImageNotifyFinished() const {
-    return m_encodedSizeOnImageNotifyFinished;
+  int imageWidthOnImageNotifyFinished() const {
+    return m_imageWidthOnImageNotifyFinished;
   }
 
  private:
+  explicit MockImageResourceObserver(ImageResourceContent*);
+
+  // ImageResourceObserver overrides.
+  void imageNotifyFinished(ImageResourceContent*) override;
+  void imageChanged(ImageResourceContent*, const IntRect*) override;
+  String debugName() const override { return "MockImageResourceObserver"; }
+
+  Persistent<ImageResourceContent> m_content;
   int m_imageChangedCount;
-  size_t m_encodedSizeOnLastImageChanged;
+  int m_imageWidthOnLastImageChanged;
   int m_imageNotifyFinishedCount;
-  size_t m_encodedSizeOnImageNotifyFinished;
+  int m_imageWidthOnImageNotifyFinished;
 };
 
 }  // namespace blink
 
-#endif  // MockImageResourceClient_h
+#endif  // MockImageResourceObserver_h