Replace Resource::Status with ResourceStatus

Replace Resource::Status with ResourceStatus

Follow-up of https://codereview.chromium.org/2537063002.

BUG=667641
Review-Url: https://codereview.chromium.org/2642383003
Cr-Commit-Position: refs/heads/master@{#445800}
Committed: https://chromium.googlesource.com/chromium/src/+/347f7a59d1fe355675e1844d0c1e2caa993985df

[hiroshige, 2017-01-20 22:05:09]

The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-20 22:05:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-20 23:57:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-20 23:57:42]

Dry run: This issue passed the CQ dry run.

[hiroshige, 2017-01-21 02:31:03]

Description was changed from

==========
Replace Resource::Status with ResourceStatus

BUG=
==========

to

==========
Replace Resource::Status with ResourceStatus

BUG=
==========

[hiroshige, 2017-01-22 20:40:26]

hiroshige@chromium.org changed reviewers:
+ toyoshim@chromium.org

[hiroshige, 2017-01-22 20:40:26]

PTAL.

[hiroshige, 2017-01-22 20:41:21]

Description was changed from

==========
Replace Resource::Status with ResourceStatus

BUG=
==========

to

==========
Replace Resource::Status with ResourceStatus

Follow-up of https://codereview.chromium.org/2537063002.

BUG=667641
==========

[Takashi Toyoshima, 2017-01-23 09:29:10]

lgtm

[kouhei (in TOK), 2017-01-23 09:47:13]

kouhei@chromium.org changed reviewers:
+ kouhei@chromium.org

[kouhei (in TOK), 2017-01-23 09:47:14]

lgtm

[hiroshige, 2017-01-23 18:47:49]

hiroshige@chromium.org changed reviewers:
+ yhirano@chromium.org

[hiroshige, 2017-01-23 18:47:50]

+yhirano PTAL as a Source/bindings OWNER.

[haraken, 2017-01-23 23:47:56]

LGTM

[kouhei (in TOK), 2017-01-24 00:30:31]

The CQ bit was checked by kouhei@chromium.org

[kouhei (in TOK), 2017-01-24 00:30:35]

The CQ bit was unchecked by kouhei@chromium.org

[yhirano, 2017-01-24 03:26:20]

lgtm

[hiroshige, 2017-01-24 06:05:08]

The CQ bit was checked by hiroshige@chromium.org

[hiroshige, 2017-01-24 06:05:14]

The CQ bit was checked by hiroshige@chromium.org

[commit-bot: I haz the power, 2017-01-24 06:05:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-24 09:02:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-24 09:02:44]

Failed to apply patch for
third_party/WebKit/Source/core/loader/resource/ImageResource.cpp:
While running git apply --index -p1;
  error: patch failed:
third_party/WebKit/Source/core/loader/resource/ImageResource.cpp:446
  error: third_party/WebKit/Source/core/loader/resource/ImageResource.cpp: patch
does not apply

Patch:       third_party/WebKit/Source/core/loader/resource/ImageResource.cpp
Index: third_party/WebKit/Source/core/loader/resource/ImageResource.cpp
diff --git a/third_party/WebKit/Source/core/loader/resource/ImageResource.cpp
b/third_party/WebKit/Source/core/loader/resource/ImageResource.cpp
index
dd1d1395b3d4b687c44cec7f393655bf55af7ba2..c95c9da9d689f7ff686b63d9057108bc711c8abd
100644
--- a/third_party/WebKit/Source/core/loader/resource/ImageResource.cpp
+++ b/third_party/WebKit/Source/core/loader/resource/ImageResource.cpp
@@ -76,9 +76,7 @@ class ImageResource::ImageResourceInfoImpl final
   const ResourceResponse& response() const override {
     return m_resource->response();
   }
-  Resource::Status getStatus() const override {
-    return m_resource->getStatus();
-  }
+  ResourceStatus getStatus() const override { return m_resource->getStatus(); }
   bool isPlaceholder() const override { return m_resource->isPlaceholder(); }
   bool isCacheValidator() const override {
     return m_resource->isCacheValidator();
@@ -329,7 +327,7 @@ void ImageResource::decodeError(bool allDataReceived) {
   clearData();
   setEncodedSize(0);
   if (!errorOccurred())
-    setStatus(DecodeError);
+    setStatus(ResourceStatus::DecodeError);
 
   if (!allDataReceived && loader()) {
     // TODO(hiroshige): Do not call didFinishLoading() directly.
@@ -446,7 +444,7 @@ void ImageResource::reloadIfLoFiOrPlaceholderImage(
         nullptr, ImageResourceContent::ClearImageAndNotifyObservers, false);
   }
 
-  setStatus(NotStarted);
+  setStatus(ResourceStatus::NotStarted);
 
   DCHECK(m_isSchedulingReload);
   m_isSchedulingReload = false;
@@ -470,7 +468,7 @@ void ImageResource::onePartInMultipartReceived(
     m_multipartParsingState = MultipartParsingState::FinishedParsingFirstPart;
     // Notify finished when the first part ends.
     if (!errorOccurred())
-      setStatus(Cached);
+      setStatus(ResourceStatus::Cached);
     // We notify clients and observers of finish in checkNotify() and
     // updateImageAndClearBuffer(), respectively, and they will not be
     // notified again in Resource::finish()/error().

[hiroshige, 2017-01-24 16:37:34]

The CQ bit was checked by hiroshige@chromium.org

[hiroshige, 2017-01-24 16:37:35]

The patchset sent to the CQ was uploaded after l-g-t-m from
haraken@chromium.org, toyoshim@chromium.org, kouhei@chromium.org,
yhirano@chromium.org
Link to the patchset: https://codereview.chromium.org/2642383003/#ps40001
(title: "Rebase")

[commit-bot: I haz the power, 2017-01-24 16:37:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-24 16:42:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-24 16:42:20]

Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[hiroshige, 2017-01-24 18:23:07]

The CQ bit was checked by hiroshige@chromium.org

[commit-bot: I haz the power, 2017-01-24 18:23:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-24 18:27:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-24 18:27:35]

Try jobs failed on following builders:
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[hiroshige, 2017-01-24 18:56:43]

The CQ bit was checked by hiroshige@chromium.org

[hiroshige, 2017-01-24 18:56:44]

The patchset sent to the CQ was uploaded after l-g-t-m from
haraken@chromium.org, toyoshim@chromium.org, kouhei@chromium.org,
yhirano@chromium.org
Link to the patchset: https://codereview.chromium.org/2642383003/#ps60001
(title: "Rebase.")

[commit-bot: I haz the power, 2017-01-24 18:57:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-24 20:46:54]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1485284203439610,
"parent_rev": "55cddd7d290b2fc35dcb4be033f8cd91424596ba", "commit_rev":
"347f7a59d1fe355675e1844d0c1e2caa993985df"}

[commit-bot: I haz the power, 2017-01-24 20:47:27]

Description was changed from

==========
Replace Resource::Status with ResourceStatus

Follow-up of https://codereview.chromium.org/2537063002.

BUG=667641
==========

to

==========
Replace Resource::Status with ResourceStatus

Follow-up of https://codereview.chromium.org/2537063002.

BUG=667641

Review-Url: https://codereview.chromium.org/2642383003
Cr-Commit-Position: refs/heads/master@{#445800}
Committed:
https://chromium.googlesource.com/chromium/src/+/347f7a59d1fe355675e1844d0c1e...
==========

[commit-bot: I haz the power, 2017-01-24 20:47:29]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/347f7a59d1fe355675e1844d0c1e...