Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Issue 2606863002: Complete XXXPaintPropertyNode::operator== and toString() (Closed)

Created:
3 years, 11 months ago by Xianzhu
Modified:
3 years, 11 months ago
Reviewers:
chrishtr
CC:
ajuma+watch_chromium.org, blink-reviews, blink-reviews-platform-graphics_chromium.org, Rik, chromium-reviews, danakj+watch_chromium.org, dshwang, drott+blinkwatch_chromium.org, krit, f(malita), jbroman, Justin Novosad, kinuko+watch, pdr+graphicswatchlist_chromium.org, rwlbuis, Stephen Chennney
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Complete XXXPaintPropertyNode::operator== and toString() operator== should check all fields that are part of paint properties. toString() should output all fields that are checked in operator==, so that we can see what changed in the failure message of paint property under-invalidation. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Committed: https://crrev.com/58a8743347a3a470ca99d8335e85439f900864c9 Cr-Commit-Position: refs/heads/master@{#440901}

Patch Set 1 #

Patch Set 2 : - #

Messages

Total messages: 20 (15 generated)
Xianzhu
3 years, 11 months ago (2016-12-28 20:32:31 UTC) #8
chrishtr
lgtm
3 years, 11 months ago (2016-12-28 20:35:05 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2606863002/20001
3 years, 11 months ago (2016-12-28 22:12:19 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
3 years, 11 months ago (2016-12-28 22:16:40 UTC) #18
commit-bot: I haz the power
3 years, 11 months ago (2017-01-02 15:50:34 UTC) #20
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/58a8743347a3a470ca99d8335e85439f900864c9
Cr-Commit-Position: refs/heads/master@{#440901}

Powered by Google App Engine
This is Rietveld 408576698