Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Side by Side Diff: third_party/WebKit/Source/platform/graphics/paint/EffectPaintPropertyNode.h

Issue 2606863002: Complete XXXPaintPropertyNode::operator== and toString() (Closed)
Patch Set: - Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef EffectPaintPropertyNode_h 5 #ifndef EffectPaintPropertyNode_h
6 #define EffectPaintPropertyNode_h 6 #define EffectPaintPropertyNode_h
7 7
8 #include "cc/layers/layer.h" 8 #include "cc/layers/layer.h"
9 #include "platform/PlatformExport.h" 9 #include "platform/PlatformExport.h"
10 #include "platform/graphics/CompositorFilterOperations.h" 10 #include "platform/graphics/CompositorFilterOperations.h"
(...skipping 74 matching lines...) Expand 10 before | Expand all | Expand 10 after
85 m_parent, m_localTransformSpace, m_outputClip, m_filter, m_opacity, 85 m_parent, m_localTransformSpace, m_outputClip, m_filter, m_opacity,
86 m_blendMode, m_directCompositingReasons)); 86 m_blendMode, m_directCompositingReasons));
87 } 87 }
88 88
89 // The equality operator is used by FindPropertiesNeedingUpdate.h for checking 89 // The equality operator is used by FindPropertiesNeedingUpdate.h for checking
90 // if an effect node has changed. It ignores changes of reference filters 90 // if an effect node has changed. It ignores changes of reference filters
91 // because SkImageFilter doesn't have an equality operator. 91 // because SkImageFilter doesn't have an equality operator.
92 bool operator==(const EffectPaintPropertyNode& o) const { 92 bool operator==(const EffectPaintPropertyNode& o) const {
93 return m_parent == o.m_parent && 93 return m_parent == o.m_parent &&
94 m_localTransformSpace == o.m_localTransformSpace && 94 m_localTransformSpace == o.m_localTransformSpace &&
95 m_outputClip == o.m_outputClip && m_opacity == o.m_opacity && 95 m_outputClip == o.m_outputClip &&
96 m_blendMode == o.m_blendMode && 96 m_filter.equalsIgnoringReferenceFilters(o.m_filter) &&
97 m_filter.equalsIgnoringReferenceFilters(o.m_filter); 97 m_opacity == o.m_opacity && m_blendMode == o.m_blendMode &&
98 m_directCompositingReasons == o.m_directCompositingReasons;
98 } 99 }
99 #endif 100 #endif
100 101
101 String toString() const; 102 String toString() const;
102 103
103 bool hasDirectCompositingReasons() const { 104 bool hasDirectCompositingReasons() const {
104 return m_directCompositingReasons != CompositingReasonNone; 105 return m_directCompositingReasons != CompositingReasonNone;
105 } 106 }
106 107
107 private: 108 private:
(...skipping 42 matching lines...) Expand 10 before | Expand all | Expand 10 after
150 CompositingReasons m_directCompositingReasons; 151 CompositingReasons m_directCompositingReasons;
151 }; 152 };
152 153
153 // Redeclared here to avoid ODR issues. 154 // Redeclared here to avoid ODR issues.
154 // See platform/testing/PaintPrinters.h. 155 // See platform/testing/PaintPrinters.h.
155 void PrintTo(const EffectPaintPropertyNode&, std::ostream*); 156 void PrintTo(const EffectPaintPropertyNode&, std::ostream*);
156 157
157 } // namespace blink 158 } // namespace blink
158 159
159 #endif // EffectPaintPropertyNode_h 160 #endif // EffectPaintPropertyNode_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698