Enable SlimmingPaintInvalidation for experiments

Enable SlimmingPaintInvalidation for experiments

Layout tests and blink perf tests will run with SlimmingPaintInvalidation
enabled.

BUG=646176
Committed: https://crrev.com/1b236220b372cebf8ca953af180c1824e478de16
Cr-Commit-Position: refs/heads/master@{#441286}

[Xianzhu, 2016-12-22 21:22:44]

The CQ bit was checked by wangxianzhu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-22 21:22:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Xianzhu, 2016-12-22 21:41:24]

Description was changed from

==========
Enable SlimmingPaintInvalidation for experiments

BUG=646176
==========

to

==========
Enable SlimmingPaintInvalidation for experiments

Layout tests and blink perf tests will run with SlimmingPaintInvalidation
enabled.

BUG=646176
==========

[Xianzhu, 2016-12-22 21:41:45]

wangxianzhu@chromium.org changed reviewers:
+ chrishtr@chromium.org, pdr@chromium.org

[pdr., 2016-12-22 21:53:47]

On 2016/12/22 at 21:41:45, wangxianzhu wrote:
> 

wooohooo!

I've been running with this flag enabled on my phone and haven't seen major
issues. I think we're ready to to this.

LGTM

[Xianzhu, 2016-12-22 21:56:02]

The CQ bit was checked by wangxianzhu@chromium.org

[commit-bot: I haz the power, 2016-12-22 21:56:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-22 23:30:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-22 23:30:18]

Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Xianzhu, 2016-12-27 17:42:54]

On 2016/12/22 23:30:18, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

We need to fix the issues found by unit tests before landing this CL. Just sent
out some CLs for review.

[chrishtr, 2016-12-27 18:07:22]

https://codereview.chromium.org/2595323003/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/TestExpectations (right):

https://codereview.chromium.org/2595323003/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/TestExpectations:105: crbug.com/646176
paint/invalidation/ [ Skip ]
Will this result in us losing coverage of this entire directory for a while?

[Xianzhu, 2016-12-27 18:48:02]

https://codereview.chromium.org/2595323003/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/TestExpectations (right):

https://codereview.chromium.org/2595323003/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/TestExpectations:105: crbug.com/646176
paint/invalidation/ [ Skip ]
On 2016/12/27 18:07:22, chrishtr wrote:
> Will this result in us losing coverage of this entire directory for a while?

The tests are still run in virtual/spinvalidation suite.

Updated the above comment.

[chrishtr, 2016-12-27 19:10:52]

https://codereview.chromium.org/2595323003/diff/40001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/TestExpectations (left):

https://codereview.chromium.org/2595323003/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/TestExpectations:113: crbug.com/645667
virtual/spinvalidation/paint/invalidation/filter-repaint-accelerated-on-accelerated-filter.html
[ Crash ]
These are now fixed?

https://codereview.chromium.org/2595323003/diff/40001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/TestExpectations (right):

https://codereview.chromium.org/2595323003/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/TestExpectations:103: # flag. The tests are still
run in visual/spinvalidation suite.
Nit: s/visual/virtual/

[Xianzhu, 2016-12-27 19:27:38]

https://codereview.chromium.org/2595323003/diff/40001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/TestExpectations (left):

https://codereview.chromium.org/2595323003/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/TestExpectations:113: crbug.com/645667
virtual/spinvalidation/paint/invalidation/filter-repaint-accelerated-on-accelerated-filter.html
[ Crash ]
On 2016/12/27 19:10:52, chrishtr wrote:
> These are now fixed?

Yes, by previous changes by pdr and me, but we forgot to update these
expectations. Separated this into https://codereview.chromium.org/2601813002 to
ease revert/reland of this CL when needed.

https://codereview.chromium.org/2595323003/diff/40001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/TestExpectations (right):

https://codereview.chromium.org/2595323003/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/TestExpectations:103: # flag. The tests are still
run in visual/spinvalidation suite.
On 2016/12/27 19:10:52, chrishtr wrote:
> Nit: s/visual/virtual/

Done.

[chrishtr, 2016-12-27 19:31:36]

lgtm

https://codereview.chromium.org/2595323003/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/layout/VisualRectMappingTest.cpp (left):

https://codereview.chromium.org/2595323003/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/layout/VisualRectMappingTest.cpp:21: void
checkPaintInvalidationStateRectMapping(
Looks like this CL got rebased wrong on top of the other one?

[Xianzhu, 2016-12-28 02:47:02]

https://codereview.chromium.org/2595323003/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/layout/VisualRectMappingTest.cpp (left):

https://codereview.chromium.org/2595323003/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/layout/VisualRectMappingTest.cpp:21: void
checkPaintInvalidationStateRectMapping(
On 2016/12/27 19:31:36, chrishtr wrote:
> Looks like this CL got rebased wrong on top of the other one?

Fixed.

[Xianzhu, 2016-12-28 02:47:05]

The CQ bit was checked by wangxianzhu@chromium.org

[Xianzhu, 2016-12-28 02:47:06]

The patchset sent to the CQ was uploaded after l-g-t-m from pdr@chromium.org,
chrishtr@chromium.org
Link to the patchset: https://codereview.chromium.org/2595323003/#ps80001
(title: "Rebase")

[commit-bot: I haz the power, 2016-12-28 02:47:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-28 03:57:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-28 03:57:52]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Xianzhu, 2016-12-28 06:37:26]

The CQ bit was checked by wangxianzhu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-28 06:37:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Xianzhu, 2016-12-28 07:02:12]

The CQ bit was checked by wangxianzhu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-28 07:02:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-28 08:14:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-28 08:14:55]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Xianzhu, 2016-12-28 18:14:35]

The CQ bit was checked by wangxianzhu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-28 18:14:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-28 20:06:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-28 20:06:18]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Xianzhu, 2016-12-28 21:15:34]

The CQ bit was checked by wangxianzhu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-28 21:15:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-28 23:02:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-28 23:02:44]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Xianzhu, 2016-12-29 00:54:54]

The CQ bit was checked by wangxianzhu@chromium.org

[Xianzhu, 2016-12-29 00:54:54]

The patchset sent to the CQ was uploaded after l-g-t-m from
chrishtr@chromium.org, pdr@chromium.org
Link to the patchset: https://codereview.chromium.org/2595323003/#ps160001
(title: "-")

[commit-bot: I haz the power, 2016-12-29 00:55:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-29 02:37:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-29 02:37:35]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Xianzhu, 2016-12-29 20:18:12]

The CQ bit was checked by wangxianzhu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-29 20:18:26]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-29 22:16:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-29 22:16:24]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Xianzhu, 2016-12-29 22:53:46]

The CQ bit was checked by wangxianzhu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-29 22:53:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-30 01:16:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-30 01:16:12]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Xianzhu, 2017-01-03 23:44:08]

The CQ bit was checked by wangxianzhu@chromium.org

[Xianzhu, 2017-01-03 23:44:09]

The patchset sent to the CQ was uploaded after l-g-t-m from
chrishtr@chromium.org, pdr@chromium.org
Link to the patchset: https://codereview.chromium.org/2595323003/#ps200001
(title: "Rebase")

[commit-bot: I haz the power, 2017-01-03 23:44:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-04 01:34:31]

CQ is committing da patch.

Bot data: {"patchset_id": 200001, "attempt_start_ts": 1483487048773820,
"parent_rev": "adeeec193e04bb54b92ddcf1bab5f4ef7affac33", "commit_rev":
"6227a9756c6eea4cd5b00c0ebf2920e84822ce43"}

[commit-bot: I haz the power, 2017-01-04 01:35:01]

Description was changed from

==========
Enable SlimmingPaintInvalidation for experiments

Layout tests and blink perf tests will run with SlimmingPaintInvalidation
enabled.

BUG=646176
==========

to

==========
Enable SlimmingPaintInvalidation for experiments

Layout tests and blink perf tests will run with SlimmingPaintInvalidation
enabled.

BUG=646176

Review-Url: https://codereview.chromium.org/2595323003
==========

[commit-bot: I haz the power, 2017-01-04 01:35:02]

Committed patchset #11 (id:200001)

[commit-bot: I haz the power, 2017-01-04 01:38:24]

Description was changed from

==========
Enable SlimmingPaintInvalidation for experiments

Layout tests and blink perf tests will run with SlimmingPaintInvalidation
enabled.

BUG=646176

Review-Url: https://codereview.chromium.org/2595323003
==========

to

==========
Enable SlimmingPaintInvalidation for experiments

Layout tests and blink perf tests will run with SlimmingPaintInvalidation
enabled.

BUG=646176

Committed: https://crrev.com/1b236220b372cebf8ca953af180c1824e478de16
Cr-Commit-Position: refs/heads/master@{#441286}
==========

[commit-bot: I haz the power, 2017-01-04 01:38:25]

Patchset 11 (id:??) landed as
https://crrev.com/1b236220b372cebf8ca953af180c1824e478de16
Cr-Commit-Position: refs/heads/master@{#441286}