Import Objective C Frameworks in components

Import Objective C Frameworks in components

The Objective-C frameworks must be imported and not included.
Command to find Objective-C frameworks
dir="`xcode-select -p`/Platforms/iPhoneOS.platform/Developer/SDKs/iPhoneOS.sdk/System/Library/Frameworks"; 
for f in `ls $dir`; do 
  name=${f%%.framework};
  grep "^\s*#import " $dir/$f/Headers/$name.h > /dev/null 2>/dev/null; 
  if [ "$?" = "0" ]; then 
    echo $name; 
  fi;
done

BUG=677965
Review-Url: https://codereview.chromium.org/2606753004
Cr-Commit-Position: refs/heads/master@{#441912}
Committed: https://chromium.googlesource.com/chromium/src/+/69709ac69519ed94ff22744fec5d7d76a7b0d67a

[Olivier, 2016-12-28 14:12:00]

olivierrobin@chromium.org changed reviewers:
+ sdefresne@chromium.org

[sdefresne, 2017-01-03 12:04:42]

lgtm

I found a few others using the following command, maybe it is worth fixing them
at the same time;

$ git grep -E 'include <([A-Z][^/]*)/(\1).h>' -- components
components/crash/content/app/breakpad_mac.mm:#include
<CoreFoundation/CoreFoundation.h>
components/crash/content/app/crashpad_mac.mm:#include
<CoreFoundation/CoreFoundation.h>
components/handoff/handoff_manager.h:#include <Foundation/Foundation.h>
components/metrics/drive_metrics_provider_mac.mm:#include
<CoreFoundation/CoreFoundation.h>
components/metrics/drive_metrics_provider_mac.mm:#include
<DiskArbitration/DiskArbitration.h>
components/metrics/drive_metrics_provider_mac.mm:#include
<Foundation/Foundation.h>
components/password_manager/core/browser/login_database_ios_unittest.cc:#include
<Security/Security.h>
components/policy/core/common/mac_util.h:#include
<CoreFoundation/CoreFoundation.h>
components/policy/core/common/mac_util_unittest.cc:#include
<CoreFoundation/CoreFoundation.h>
components/policy/core/common/policy_loader_ios_unittest.mm:#include
<UIKit/UIKit.h>
components/policy/core/common/policy_loader_mac_unittest.cc:#include
<CoreFoundation/CoreFoundation.h>
components/policy/core/common/policy_test_utils.cc:#include
<CoreFoundation/CoreFoundation.h>
components/policy/core/common/preferences_mac.h:#include
<CoreFoundation/CoreFoundation.h>
components/signin/ios/browser/account_consistency_service.mm:#include
<WebKit/WebKit.h>
components/signin/ios/browser/fake_profile_oauth2_token_service_ios_provider.mm:#include
<Foundation/Foundation.h>
components/signin/ios/browser/profile_oauth2_token_service_ios_delegate.mm:#include
<Foundation/Foundation.h>
components/storage_monitor/storage_monitor_mac.h:#include
<DiskArbitration/DiskArbitration.h>

https://codereview.chromium.org/2606753004/diff/1/components/metrics/drive_me...
File components/metrics/drive_metrics_provider_mac.mm (right):

https://codereview.chromium.org/2606753004/diff/1/components/metrics/drive_me...
components/metrics/drive_metrics_provider_mac.mm:7: #include
<CoreFoundation/CoreFoundation.h>
#import

https://codereview.chromium.org/2606753004/diff/1/components/metrics/drive_me...
components/metrics/drive_metrics_provider_mac.mm:8: #include
<DiskArbitration/DiskArbitration.h>
#import

[sdefresne, 2017-01-03 12:05:20]

On 2017/01/03 12:04:42, sdefresne wrote:
> lgtm
> 
> I found a few others using the following command, maybe it is worth fixing
them
> at the same time;
> 
> $ git grep -E 'include <([A-Z][^/]*)/(\1).h>' -- components
> components/crash/content/app/breakpad_mac.mm:#include
> <CoreFoundation/CoreFoundation.h>
> components/crash/content/app/crashpad_mac.mm:#include
> <CoreFoundation/CoreFoundation.h>
> components/handoff/handoff_manager.h:#include <Foundation/Foundation.h>
> components/metrics/drive_metrics_provider_mac.mm:#include
> <CoreFoundation/CoreFoundation.h>
> components/metrics/drive_metrics_provider_mac.mm:#include
> <DiskArbitration/DiskArbitration.h>
> components/metrics/drive_metrics_provider_mac.mm:#include
> <Foundation/Foundation.h>
>
components/password_manager/core/browser/login_database_ios_unittest.cc:#include
> <Security/Security.h>
> components/policy/core/common/mac_util.h:#include
> <CoreFoundation/CoreFoundation.h>
> components/policy/core/common/mac_util_unittest.cc:#include
> <CoreFoundation/CoreFoundation.h>
> components/policy/core/common/policy_loader_ios_unittest.mm:#include
> <UIKit/UIKit.h>
> components/policy/core/common/policy_loader_mac_unittest.cc:#include
> <CoreFoundation/CoreFoundation.h>
> components/policy/core/common/policy_test_utils.cc:#include
> <CoreFoundation/CoreFoundation.h>
> components/policy/core/common/preferences_mac.h:#include
> <CoreFoundation/CoreFoundation.h>
> components/signin/ios/browser/account_consistency_service.mm:#include
> <WebKit/WebKit.h>
>
components/signin/ios/browser/fake_profile_oauth2_token_service_ios_provider.mm:#include
> <Foundation/Foundation.h>
>
components/signin/ios/browser/profile_oauth2_token_service_ios_delegate.mm:#include
> <Foundation/Foundation.h>
> components/storage_monitor/storage_monitor_mac.h:#include
> <DiskArbitration/DiskArbitration.h>
> 
>
https://codereview.chromium.org/2606753004/diff/1/components/metrics/drive_me...
> File components/metrics/drive_metrics_provider_mac.mm (right):
> 
>
https://codereview.chromium.org/2606753004/diff/1/components/metrics/drive_me...
> components/metrics/drive_metrics_provider_mac.mm:7: #include
> <CoreFoundation/CoreFoundation.h>
> #import
> 
>
https://codereview.chromium.org/2606753004/diff/1/components/metrics/drive_me...
> components/metrics/drive_metrics_provider_mac.mm:8: #include
> <DiskArbitration/DiskArbitration.h>
> #import

BTW, if you do, can you update description to not list all framework, but just
mention the command used to find them?

[Olivier, 2017-01-03 12:32:28]

Description was changed from

==========
Import Objective C Frameworks in components

The Objective-C frameworks must be imported and not included.
List of Objective-C Frameworks that have been checked:
AVFoundation
AVKit
Accounts
AdSupport
AddressBookUI
AssetsLibrary
CallKit
CloudKit
Contacts
ContactsUI
CoreAudioKit
CoreBluetooth
CoreData
CoreImage
CoreLocation
CoreMIDI
CoreMotion
CoreSpotlight
EventKit
EventKitUI
ExternalAccessory
Foundation
GLKit
GameController
GameKit
GameplayKit
HealthKit
HealthKitUI
HomeKit
Intents
IntentsUI
JavaScriptCore
LocalAuthentication
MapKit
MediaPlayer
MessageUI
Messages
Metal
MetalKit
MetalPerformanceShaders
ModelIO
MultipeerConnectivity
NetworkExtension
NewsstandKit
NotificationCenter
PassKit
Photos
PhotosUI
PushKit
QuickLook
ReplayKit
SafariServices
SceneKit
Social
Speech
SpriteKit
StoreKit
Twitter
UIKit
UserNotifications
UserNotificationsUI
VideoSubscriberAccount
WatchConnectivity
WatchKit
WebKit
iAd

BUG=None
==========

to

==========
Import Objective C Frameworks in components

The Objective-C frameworks must be imported and not included.
Command to find Objective-C frameworks
dir="`xcode-select
-p`/Platforms/iPhoneOS.platform/Developer/SDKs/iPhoneOS.sdk/System/Library/Frameworks";

for f in `ls $dir`; do 
  name=${f%%.framework};
  grep "^\s*#import " $dir/$f/Headers/$name.h > /dev/null 2>/dev/null; 
  if [ "$?" = "0" ]; then 
    echo $name; 
  fi;
done

List of Objective-C Frameworks that have been checked:
AVFoundation
AVKit
Accounts
AdSupport
AddressBookUI
AssetsLibrary
CallKit
CloudKit
Contacts
ContactsUI
CoreAudioKit
CoreBluetooth
CoreData
CoreImage
CoreLocation
CoreMIDI
CoreMotion
CoreSpotlight
EventKit
EventKitUI
ExternalAccessory
Foundation
GLKit
GameController
GameKit
GameplayKit
HealthKit
HealthKitUI
HomeKit
Intents
IntentsUI
JavaScriptCore
LocalAuthentication
MapKit
MediaPlayer
MessageUI
Messages
Metal
MetalKit
MetalPerformanceShaders
ModelIO
MultipeerConnectivity
NetworkExtension
NewsstandKit
NotificationCenter
PassKit
Photos
PhotosUI
PushKit
QuickLook
ReplayKit
SafariServices
SceneKit
Social
Speech
SpriteKit
StoreKit
Twitter
UIKit
UserNotifications
UserNotificationsUI
VideoSubscriberAccount
WatchConnectivity
WatchKit
WebKit
iAd

BUG=None
==========

[Olivier, 2017-01-03 12:32:51]

Description was changed from

==========
Import Objective C Frameworks in components

The Objective-C frameworks must be imported and not included.
Command to find Objective-C frameworks
dir="`xcode-select
-p`/Platforms/iPhoneOS.platform/Developer/SDKs/iPhoneOS.sdk/System/Library/Frameworks";

for f in `ls $dir`; do 
  name=${f%%.framework};
  grep "^\s*#import " $dir/$f/Headers/$name.h > /dev/null 2>/dev/null; 
  if [ "$?" = "0" ]; then 
    echo $name; 
  fi;
done

List of Objective-C Frameworks that have been checked:
AVFoundation
AVKit
Accounts
AdSupport
AddressBookUI
AssetsLibrary
CallKit
CloudKit
Contacts
ContactsUI
CoreAudioKit
CoreBluetooth
CoreData
CoreImage
CoreLocation
CoreMIDI
CoreMotion
CoreSpotlight
EventKit
EventKitUI
ExternalAccessory
Foundation
GLKit
GameController
GameKit
GameplayKit
HealthKit
HealthKitUI
HomeKit
Intents
IntentsUI
JavaScriptCore
LocalAuthentication
MapKit
MediaPlayer
MessageUI
Messages
Metal
MetalKit
MetalPerformanceShaders
ModelIO
MultipeerConnectivity
NetworkExtension
NewsstandKit
NotificationCenter
PassKit
Photos
PhotosUI
PushKit
QuickLook
ReplayKit
SafariServices
SceneKit
Social
Speech
SpriteKit
StoreKit
Twitter
UIKit
UserNotifications
UserNotificationsUI
VideoSubscriberAccount
WatchConnectivity
WatchKit
WebKit
iAd

BUG=None
==========

to

==========
Import Objective C Frameworks in components

The Objective-C frameworks must be imported and not included.
Command to find Objective-C frameworks
dir="`xcode-select
-p`/Platforms/iPhoneOS.platform/Developer/SDKs/iPhoneOS.sdk/System/Library/Frameworks";

for f in `ls $dir`; do 
  name=${f%%.framework};
  grep "^\s*#import " $dir/$f/Headers/$name.h > /dev/null 2>/dev/null; 
  if [ "$?" = "0" ]; then 
    echo $name; 
  fi;
done

BUG=None
==========

[Olivier, 2017-01-03 12:33:07]

Done

https://codereview.chromium.org/2606753004/diff/1/components/metrics/drive_me...
File components/metrics/drive_metrics_provider_mac.mm (right):

https://codereview.chromium.org/2606753004/diff/1/components/metrics/drive_me...
components/metrics/drive_metrics_provider_mac.mm:7: #include
<CoreFoundation/CoreFoundation.h>
On 2017/01/03 12:04:42, sdefresne wrote:
> #import

CoreFoundation is a C++ Framework and must be included.

https://codereview.chromium.org/2606753004/diff/1/components/metrics/drive_me...
components/metrics/drive_metrics_provider_mac.mm:8: #include
<DiskArbitration/DiskArbitration.h>
On 2017/01/03 12:04:42, sdefresne wrote:
> #import

DiskArbitration is a C++ framework (and MacOS only) so it must be included.

[Olivier, 2017-01-03 15:20:31]

Description was changed from

==========
Import Objective C Frameworks in components

The Objective-C frameworks must be imported and not included.
Command to find Objective-C frameworks
dir="`xcode-select
-p`/Platforms/iPhoneOS.platform/Developer/SDKs/iPhoneOS.sdk/System/Library/Frameworks";

for f in `ls $dir`; do 
  name=${f%%.framework};
  grep "^\s*#import " $dir/$f/Headers/$name.h > /dev/null 2>/dev/null; 
  if [ "$?" = "0" ]; then 
    echo $name; 
  fi;
done

BUG=None
==========

to

==========
Import Objective C Frameworks in components

The Objective-C frameworks must be imported and not included.
Command to find Objective-C frameworks
dir="`xcode-select
-p`/Platforms/iPhoneOS.platform/Developer/SDKs/iPhoneOS.sdk/System/Library/Frameworks";

for f in `ls $dir`; do 
  name=${f%%.framework};
  grep "^\s*#import " $dir/$f/Headers/$name.h > /dev/null 2>/dev/null; 
  if [ "$?" = "0" ]; then 
    echo $name; 
  fi;
done

BUG=677965
==========

[Olivier, 2017-01-06 09:45:11]

The CQ bit was checked by olivierrobin@chromium.org

[commit-bot: I haz the power, 2017-01-06 09:45:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-06 10:11:59]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1483695911300580, "parent_rev":
"110425bcd5ef3ea734625d084af49723990ae0c8", "commit_rev":
"69709ac69519ed94ff22744fec5d7d76a7b0d67a"}

[commit-bot: I haz the power, 2017-01-06 10:12:26]

Description was changed from

==========
Import Objective C Frameworks in components

The Objective-C frameworks must be imported and not included.
Command to find Objective-C frameworks
dir="`xcode-select
-p`/Platforms/iPhoneOS.platform/Developer/SDKs/iPhoneOS.sdk/System/Library/Frameworks";

for f in `ls $dir`; do 
  name=${f%%.framework};
  grep "^\s*#import " $dir/$f/Headers/$name.h > /dev/null 2>/dev/null; 
  if [ "$?" = "0" ]; then 
    echo $name; 
  fi;
done

BUG=677965
==========

to

==========
Import Objective C Frameworks in components

The Objective-C frameworks must be imported and not included.
Command to find Objective-C frameworks
dir="`xcode-select
-p`/Platforms/iPhoneOS.platform/Developer/SDKs/iPhoneOS.sdk/System/Library/Frameworks";

for f in `ls $dir`; do 
  name=${f%%.framework};
  grep "^\s*#import " $dir/$f/Headers/$name.h > /dev/null 2>/dev/null; 
  if [ "$?" = "0" ]; then 
    echo $name; 
  fi;
done

BUG=677965

Review-Url: https://codereview.chromium.org/2606753004
Cr-Commit-Position: refs/heads/master@{#441912}
Committed:
https://chromium.googlesource.com/chromium/src/+/69709ac69519ed94ff22744fec5d...
==========

[commit-bot: I haz the power, 2017-01-06 10:12:27]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/69709ac69519ed94ff22744fec5d...