Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Side by Side Diff: components/metrics/drive_metrics_provider_mac.mm

Issue 2606753004: Import Objective C Frameworks in components (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/metrics/drive_metrics_provider.h" 5 #include "components/metrics/drive_metrics_provider.h"
6 6
7 #include <CoreFoundation/CoreFoundation.h> 7 #include <CoreFoundation/CoreFoundation.h>
sdefresne 2017/01/03 12:04:42 #import
Olivier 2017/01/03 12:33:07 CoreFoundation is a C++ Framework and must be incl
8 #include <DiskArbitration/DiskArbitration.h> 8 #include <DiskArbitration/DiskArbitration.h>
sdefresne 2017/01/03 12:04:42 #import
Olivier 2017/01/03 12:33:07 DiskArbitration is a C++ framework (and MacOS only
9 #include <Foundation/Foundation.h> 9 #import <Foundation/Foundation.h>
10 #include <IOKit/IOKitLib.h> 10 #include <IOKit/IOKitLib.h>
11 #include <IOKit/storage/IOStorageDeviceCharacteristics.h> 11 #include <IOKit/storage/IOStorageDeviceCharacteristics.h>
12 #include <stdlib.h> 12 #include <stdlib.h>
13 #include <sys/stat.h> 13 #include <sys/stat.h>
14 14
15 #include "base/files/file_path.h" 15 #include "base/files/file_path.h"
16 #include "base/mac/foundation_util.h" 16 #include "base/mac/foundation_util.h"
17 #include "base/mac/mac_util.h" 17 #include "base/mac/mac_util.h"
18 #include "base/mac/scoped_cftyperef.h" 18 #include "base/mac/scoped_cftyperef.h"
19 #include "base/mac/scoped_ioobject.h" 19 #include "base/mac/scoped_ioobject.h"
(...skipping 47 matching lines...) Expand 10 before | Expand all | Expand 10 after
67 return true; 67 return true;
68 } 68 }
69 69
70 // TODO(dbeam): should I look for these Rotational/Solid State keys in 70 // TODO(dbeam): should I look for these Rotational/Solid State keys in
71 // |characteristics|? What if I find device characteristic but there's no 71 // |characteristics|? What if I find device characteristic but there's no
72 // type? Assume rotational? 72 // type? Assume rotational?
73 return false; 73 return false;
74 } 74 }
75 75
76 } // namespace metrics 76 } // namespace metrics
OLDNEW
« no previous file with comments | « components/handoff/handoff_manager.h ('k') | components/policy/core/common/policy_loader_ios_unittest.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698