components/metrics/drive_metrics_provider_mac.mm - Issue 2606753004: Import Objective C Frameworks in components

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/metrics/drive_metrics_provider_mac.mm

Issue 2606753004: Import Objective C Frameworks in components (Closed)

Patch Set: Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/metrics/drive_metrics_provider_mac.mm

diff --git a/components/metrics/drive_metrics_provider_mac.mm b/components/metrics/drive_metrics_provider_mac.mm

index a6a37614d0cccf595d2c7175bfd869d6c2d0af79..421419b75a02c4ccae361f49923dcb9d3c567b2c 100644

--- a/components/metrics/drive_metrics_provider_mac.mm

+++ b/components/metrics/drive_metrics_provider_mac.mm

@@ -6,7 +6,7 @@

#include <CoreFoundation/CoreFoundation.h>

sdefresne 2017/01/03 12:04:42 #import

Olivier 2017/01/03 12:33:07 CoreFoundation is a C++ Framework and must be incl

#include <DiskArbitration/DiskArbitration.h>

sdefresne 2017/01/03 12:04:42 #import

Olivier 2017/01/03 12:33:07 DiskArbitration is a C++ framework (and MacOS only

-#include <Foundation/Foundation.h>

+#import <Foundation/Foundation.h>

#include <IOKit/IOKitLib.h>

#include <IOKit/storage/IOStorageDeviceCharacteristics.h>

#include <stdlib.h>