Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Issue 2605543002: Replace adjustment of previous visual rects on scroll with normal paint invalidation (Closed)

Created:
3 years, 12 months ago by Xianzhu
Modified:
3 years, 11 months ago
Reviewers:
chrishtr, wkorman
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, blink-reviews-layout_chromium.org, blink-reviews-paint_chromium.org, chromium-reviews, dshwang, eae+blinkwatch, Eric Willigers, jchaffraix+rendering, kinuko+watch, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, rjwright, shans, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace adjustment of previous visual rects on scroll with normal paint invalidation Previously the adjustment of previous visual rects on scroll was not complete: it ignored non-layered objects, and didn't adjust location in backing. Now set paint invalidation flag on scroll if needed, and all required adjustments will be done during paint invalidation. BUG=673197 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Committed: https://crrev.com/03444642622ffcecb8197bf40d6a21495d694240 Cr-Commit-Position: refs/heads/master@{#440763}

Patch Set 1 #

Patch Set 2 : - #

Patch Set 3 : Remove unused parameters #

Messages

Total messages: 22 (17 generated)
Xianzhu
3 years, 12 months ago (2016-12-27 17:38:38 UTC) #14
chrishtr
lgtm
3 years, 12 months ago (2016-12-27 17:58:47 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2605543002/40001
3 years, 12 months ago (2016-12-27 17:59:09 UTC) #17
commit-bot: I haz the power
Committed patchset #3 (id:40001)
3 years, 12 months ago (2016-12-27 18:02:44 UTC) #20
commit-bot: I haz the power
3 years, 11 months ago (2017-01-02 15:46:27 UTC) #22
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/03444642622ffcecb8197bf40d6a21495d694240
Cr-Commit-Position: refs/heads/master@{#440763}

Powered by Google App Engine
This is Rietveld 408576698