Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(602)

Unified Diff: third_party/WebKit/Source/core/paint/PaintLayer.cpp

Issue 2605543002: Replace adjustment of previous visual rects on scroll with normal paint invalidation (Closed)
Patch Set: Remove unused parameters Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/paint/PaintLayer.cpp
diff --git a/third_party/WebKit/Source/core/paint/PaintLayer.cpp b/third_party/WebKit/Source/core/paint/PaintLayer.cpp
index 4f39b06088c6dcdf14872d18b80e9ab4d8baa891..7a098e407c3170d03fdbc948ebb001ca222ec3f6 100644
--- a/third_party/WebKit/Source/core/paint/PaintLayer.cpp
+++ b/third_party/WebKit/Source/core/paint/PaintLayer.cpp
@@ -295,15 +295,6 @@ void PaintLayer::updateLayerPositionsAfterLayout() {
void PaintLayer::updateLayerPositionRecursive() {
updateLayerPosition();
- // FIXME(400589): We would like to do this in
- // PaintLayerScrollableArea::updateAfterLayout, but it depends on the size
- // computed by updateLayerPosition.
- if (m_scrollableArea) {
- if (ScrollAnimatorBase* scrollAnimator =
- m_scrollableArea->existingScrollAnimator())
- scrollAnimator->updateAfterLayout();
- }
-
for (PaintLayer* child = firstChild(); child; child = child->nextSibling())
child->updateLayerPositionRecursive();
}
@@ -378,35 +369,9 @@ bool PaintLayer::scrollsWithRespectTo(const PaintLayer* other) const {
return ancestorScrollingLayer() != other->ancestorScrollingLayer();
}
-void PaintLayer::updateLayerPositionsAfterOverflowScroll(
- const DoubleSize& scrollDelta) {
+void PaintLayer::updateLayerPositionsAfterOverflowScroll() {
clipper().clearClipRectsIncludingDescendants();
- updateLayerPositionsAfterScrollRecursive(scrollDelta,
- isPaintInvalidationContainer());
-}
-
-void PaintLayer::updateLayerPositionsAfterScrollRecursive(
- const DoubleSize& scrollDelta,
- bool paintInvalidationContainerWasScrolled) {
- updateLayerPosition();
- if (paintInvalidationContainerWasScrolled &&
- !isPaintInvalidationContainer()) {
- // Paint invalidation rects are in the coordinate space of the paint
- // invalidation container. If it has scrolled, the rect must be adjusted.
- // Note that it is not safe to reset it to the current bounds rect, as the
- // LayoutObject may have moved since the
- // last invalidation.
- // FIXME(416535): Ideally, pending invalidations of scrolling content should
- // be stored in the coordinate space of the scrolling content layer, so that
- // they need no adjustment.
- m_layoutObject->adjustPreviousPaintInvalidationForScrollIfNeeded(
- scrollDelta);
- }
- for (PaintLayer* child = firstChild(); child; child = child->nextSibling()) {
- child->updateLayerPositionsAfterScrollRecursive(
- scrollDelta, paintInvalidationContainerWasScrolled &&
- !child->isPaintInvalidationContainer());
- }
+ updateLayerPositionRecursive();
}
void PaintLayer::updateTransformationMatrix() {
« no previous file with comments | « third_party/WebKit/Source/core/paint/PaintLayer.h ('k') | third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698