Make VisualRectMappingTest suitable for SlimmingPaintInvalidation

Make VisualRectMappingTest suitable for SlimmingPaintInvalidation

Now check visualRect() instead of creating PaintInvalidationStates.

BUG=646176
Committed: https://crrev.com/a9f35f4a77671af37670284dbb93bff0c46705c4
Cr-Commit-Position: refs/heads/master@{#440795}

[Xianzhu, 2016-12-23 23:35:26]

The CQ bit was checked by wangxianzhu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-23 23:35:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-24 01:05:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-24 01:05:46]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Xianzhu, 2016-12-26 20:05:20]

The CQ bit was checked by wangxianzhu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-26 20:05:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Xianzhu, 2016-12-26 20:06:26]

Description was changed from

==========
Make VisualRectMappingTest suitable for SlimmingPaintInvalidation

BUG=646176
==========

to

==========
Make VisualRectMappingTest suitable for SlimmingPaintInvalidation

Now check visualRect() instead of creating PaintInvalidationStates.

BUG=646176
==========

[commit-bot: I haz the power, 2016-12-26 22:19:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-26 22:19:15]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Xianzhu, 2016-12-27 17:40:42]

The CQ bit was checked by wangxianzhu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-27 17:40:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Xianzhu, 2016-12-27 17:40:56]

wangxianzhu@chromium.org changed reviewers:
+ chrishtr@chromium.org, wkorman@chromium.org

[chrishtr, 2016-12-27 18:04:39]

https://codereview.chromium.org/2599363002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/layout/VisualRectMappingTest.cpp (right):

https://codereview.chromium.org/2599363002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/layout/VisualRectMappingTest.cpp:633:
PaintLayer::mapRectInPaintInvalidationContainerToBacking(*stackingContext,
Why does this one need special handling?

[Xianzhu, 2016-12-27 18:38:50]

https://codereview.chromium.org/2599363002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/layout/VisualRectMappingTest.cpp (right):

https://codereview.chromium.org/2599363002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/layout/VisualRectMappingTest.cpp:633:
PaintLayer::mapRectInPaintInvalidationContainerToBacking(*stackingContext,
On 2016/12/27 18:04:39, chrishtr wrote:
> Why does this one need special handling?

This is needed because the stackingContext layer is squashed, and squashing has
been dealt with for visualRect.

There is no squashing in other test cases so I simply compare the output of
mapToVisualRectInAncestorSpace and visualRect.

Changed checkPaintInvalidationVisualRect() to support squashing and call the
function here. Added comments.

[chrishtr, 2016-12-27 19:17:24]

lgtm

https://codereview.chromium.org/2599363002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/layout/VisualRectMappingTest.cpp (right):

https://codereview.chromium.org/2599363002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/layout/VisualRectMappingTest.cpp:639: // Use
checkPaintInvalidationVisualRect to deals with layer squashing.
Nit: s/deals/deal/

[Xianzhu, 2016-12-27 20:45:25]

The CQ bit was checked by wangxianzhu@chromium.org

[Xianzhu, 2016-12-27 20:45:25]

The patchset sent to the CQ was uploaded after l-g-t-m from
chrishtr@chromium.org
Link to the patchset: https://codereview.chromium.org/2599363002/#ps60001
(title: "Update comments")

[commit-bot: I haz the power, 2016-12-27 20:45:38]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Xianzhu, 2016-12-27 20:45:43]

https://codereview.chromium.org/2599363002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/layout/VisualRectMappingTest.cpp (right):

https://codereview.chromium.org/2599363002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/layout/VisualRectMappingTest.cpp:639: // Use
checkPaintInvalidationVisualRect to deals with layer squashing.
On 2016/12/27 19:17:24, chrishtr wrote:
> Nit: s/deals/deal/

Done.

[commit-bot: I haz the power, 2016-12-27 22:11:07]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1482871525335010,
"parent_rev": "af10ce96ffb6fe78781b5c3fb7e0060452f3127d", "commit_rev":
"754d3b8aa7f55e34ac60158048ed969ff362a2a6"}

[commit-bot: I haz the power, 2016-12-27 22:11:39]

Description was changed from

==========
Make VisualRectMappingTest suitable for SlimmingPaintInvalidation

Now check visualRect() instead of creating PaintInvalidationStates.

BUG=646176
==========

to

==========
Make VisualRectMappingTest suitable for SlimmingPaintInvalidation

Now check visualRect() instead of creating PaintInvalidationStates.

BUG=646176

Review-Url: https://codereview.chromium.org/2599363002
==========

[commit-bot: I haz the power, 2016-12-27 22:11:40]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2017-01-02 15:47:28]

Description was changed from

==========
Make VisualRectMappingTest suitable for SlimmingPaintInvalidation

Now check visualRect() instead of creating PaintInvalidationStates.

BUG=646176

Review-Url: https://codereview.chromium.org/2599363002
==========

to

==========
Make VisualRectMappingTest suitable for SlimmingPaintInvalidation

Now check visualRect() instead of creating PaintInvalidationStates.

BUG=646176

Committed: https://crrev.com/a9f35f4a77671af37670284dbb93bff0c46705c4
Cr-Commit-Position: refs/heads/master@{#440795}
==========

[commit-bot: I haz the power, 2017-01-02 15:47:29]

Patchset 4 (id:??) landed as
https://crrev.com/a9f35f4a77671af37670284dbb93bff0c46705c4
Cr-Commit-Position: refs/heads/master@{#440795}