[DevTools] Add grow mode to ListControl.

[DevTools] Add grow mode to ListControl.

BUG=none

Committed: https://crrev.com/abc48db4471b606de4d318284e4454e656b4353b
Cr-Commit-Position: refs/heads/master@{#441006}

[dgozman, 2016-12-29 18:53:57]

The CQ bit was checked by dgozman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-29 18:54:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dgozman, 2016-12-29 18:54:58]

dgozman@chromium.org changed reviewers:
+ caseq@chromium.org

[dgozman, 2016-12-29 18:54:59]

Could you please take a look?

[caseq, 2016-12-29 19:25:31]

lgtm

https://codereview.chromium.org/2605253002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/ui/ListControl.js (right):

https://codereview.chromium.org/2605253002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/ui/ListControl.js:94: setMode(mode)
{
Should we even allow changing mode on the fly? Perhaps move this into the
constructor?

https://codereview.chromium.org/2605253002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/ui/ListControl.js:97:
this.element.removeEventListener('scroll', this._boundScroll, false);
do it unconditionally just in case?

https://codereview.chromium.org/2605253002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/ui/ListControl.js:98: this._mode =
mode;
this would go before if then

https://codereview.chromium.org/2605253002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/ui/ListControl.js:111: if
(this._mode === UI.ListMode.Grow)
this can't be true :-)

https://codereview.chromium.org/2605253002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/ui/ListControl.js:328: for (var i =
0; i < this._items.length; i++) {
use findIndex()?

https://codereview.chromium.org/2605253002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/ui/ListControl.js:495: if
(this._mode === UI.ListMode.Grow) {
nit: move up

https://codereview.chromium.org/2605253002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/ui/ListControl.js:545: startElement
= startElement.nextSibling;
nextElementSibling

https://codereview.chromium.org/2605253002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/ui/ListControl.js:546: for (var
index = 0; index < remove; index++)
nit: while (remove--)

https://codereview.chromium.org/2605253002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/ui/ListControl.js:547:
startElement.nextSibling.remove();
ditto.

https://codereview.chromium.org/2605253002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/ui/SuggestBox.js (right):

https://codereview.chromium.org/2605253002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/ui/SuggestBox.js:389:
this._list.setMode(UI.ListMode.ViewportFixedItems);
let's have a dedicated method to reset height?

https://codereview.chromium.org/2605253002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/ui_lazy/FilteredListWidget.js
(right):

https://codereview.chromium.org/2605253002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/ui_lazy/FilteredListWidget.js:90:
this._list.setMode(UI.ListMode.ViewportFixedItemsMeasured);
ditto. also, consider moving to wasShown()

[dgozman, 2016-12-29 20:38:44]

https://codereview.chromium.org/2605253002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/ui/ListControl.js (right):

https://codereview.chromium.org/2605253002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/ui/ListControl.js:94: setMode(mode)
{
On 2016/12/29 19:25:31, caseq wrote:
> Should we even allow changing mode on the fly? Perhaps move this into the
> constructor?

Done.

https://codereview.chromium.org/2605253002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/ui/ListControl.js:328: for (var i =
0; i < this._items.length; i++) {
On 2016/12/29 19:25:31, caseq wrote:
> use findIndex()?

Done.

https://codereview.chromium.org/2605253002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/ui/ListControl.js:495: if
(this._mode === UI.ListMode.Grow) {
On 2016/12/29 19:25:31, caseq wrote:
> nit: move up

Done.

https://codereview.chromium.org/2605253002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/ui/ListControl.js:545: startElement
= startElement.nextSibling;
On 2016/12/29 19:25:31, caseq wrote:
> nextElementSibling

Done.

https://codereview.chromium.org/2605253002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/ui/ListControl.js:546: for (var
index = 0; index < remove; index++)
On 2016/12/29 19:25:30, caseq wrote:
> nit: while (remove--)

Done.

[dgozman, 2016-12-29 20:39:12]

The CQ bit was checked by dgozman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-29 20:39:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-29 22:10:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-29 22:10:01]

Dry run: This issue passed the CQ dry run.

[dgozman, 2016-12-29 23:43:24]

The CQ bit was checked by dgozman@chromium.org

[dgozman, 2016-12-29 23:43:25]

The patchset sent to the CQ was uploaded after l-g-t-m from caseq@chromium.org
Link to the patchset: https://codereview.chromium.org/2605253002/#ps40001
(title: "addressed review comments")

[commit-bot: I haz the power, 2016-12-29 23:43:40]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-29 23:47:48]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1483055004805780,
"parent_rev": "2e9ec6fdb9f1bac9cdb94a0811e3e09648f8af20", "commit_rev":
"2063dcddc6c6c41a4f5f71b9525bda36146bdab2"}

[commit-bot: I haz the power, 2016-12-29 23:48:14]

Description was changed from

==========
[DevTools] Add grow mode to ListControl.

BUG=none
==========

to

==========
[DevTools] Add grow mode to ListControl.

BUG=none

Review-Url: https://codereview.chromium.org/2605253002
==========

[commit-bot: I haz the power, 2016-12-29 23:48:15]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2017-01-02 15:53:49]

Description was changed from

==========
[DevTools] Add grow mode to ListControl.

BUG=none

Review-Url: https://codereview.chromium.org/2605253002
==========

to

==========
[DevTools] Add grow mode to ListControl.

BUG=none

Committed: https://crrev.com/abc48db4471b606de4d318284e4454e656b4353b
Cr-Commit-Position: refs/heads/master@{#441006}
==========

[commit-bot: I haz the power, 2017-01-02 15:53:50]

Patchset 3 (id:??) landed as
https://crrev.com/abc48db4471b606de4d318284e4454e656b4353b
Cr-Commit-Position: refs/heads/master@{#441006}