third_party/WebKit/LayoutTests/http/tests/inspector-unit/list-control-variable-height.js - Issue 2605253002: [DevTools] Add grow mode to ListControl.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/http/tests/inspector-unit/list-control-variable-height.js

Issue 2605253002: [DevTools] Add grow mode to ListControl. (Closed)

Patch Set: addressed review comments Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/http/tests/inspector-unit/list-control-grow-expected.txt ('k') | third_party/WebKit/Source/devtools/front_end/ui/ListControl.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/http/tests/inspector-unit/list-control-variable-height.js

diff --git a/third_party/WebKit/LayoutTests/http/tests/inspector-unit/list-control-variable-height.js b/third_party/WebKit/LayoutTests/http/tests/inspector-unit/list-control-variable-height.js

index bc49549bc6576d24c821225e0fddfeb71a6bf330..4d3392f5b91e2db98a3e3955b5e92562e1693f44 100644

--- a/third_party/WebKit/LayoutTests/http/tests/inspector-unit/list-control-variable-height.js

+++ b/third_party/WebKit/LayoutTests/http/tests/inspector-unit/list-control-variable-height.js

@@ -30,8 +30,7 @@ class Delegate {

}

var delegate = new Delegate();

-var list = new UI.ListControl(delegate);

-list.setHeightMode(UI.ListHeightMode.Variable);

+var list = new UI.ListControl(delegate, UI.ListMode.ViewportVariableItems);

list.element.style.height = '73px';

UI.inspectorView.element.appendChild(list.element);