Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Unified Diff: third_party/WebKit/Source/devtools/front_end/ui_lazy/FilteredListWidget.js

Issue 2605253002: [DevTools] Add grow mode to ListControl. (Closed)
Patch Set: addressed review comments Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/ui/SuggestBox.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/devtools/front_end/ui_lazy/FilteredListWidget.js
diff --git a/third_party/WebKit/Source/devtools/front_end/ui_lazy/FilteredListWidget.js b/third_party/WebKit/Source/devtools/front_end/ui_lazy/FilteredListWidget.js
index 64dfe06f40bb5362507218f75fd22316e4c52355..e55d2d8e3bed3806dfac20e08e00370515ad27cc 100644
--- a/third_party/WebKit/Source/devtools/front_end/ui_lazy/FilteredListWidget.js
+++ b/third_party/WebKit/Source/devtools/front_end/ui_lazy/FilteredListWidget.js
@@ -36,7 +36,7 @@ UI.FilteredListWidget = class extends UI.VBox {
this._progressBarElement = this._progressElement.createChild('div', 'filtered-list-widget-progress-bar');
/** @type {!UI.ListControl<number>} */
- this._list = new UI.ListControl(this);
+ this._list = new UI.ListControl(this, UI.ListMode.ViewportFixedItemsMeasured);
this._itemElementsContainer = this._list.element;
this._itemElementsContainer.classList.add('container');
this._itemElementsContainer.addEventListener('click', this._onClick.bind(this), false);
@@ -86,8 +86,14 @@ UI.FilteredListWidget = class extends UI.VBox {
/**
* @override
*/
+ wasShown() {
+ this._list.fixedHeightChanged();
+ }
+
+ /**
+ * @override
+ */
willHide() {
- this._list.setHeightMode(UI.ListHeightMode.Measured);
this._delegate.dispose();
if (this._filterTimer)
clearTimeout(this._filterTimer);
« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/ui/SuggestBox.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698