Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(619)

Issue 2605103002: Add example cases in unit tests for tests with "Slow" expectations. (Closed)

Created:
3 years, 11 months ago by qyearsley
Modified:
3 years, 11 months ago
Reviewers:
jeffcarp
CC:
blink-reviews, blink-reviews-w3ctests_chromium.org, cbentzel+watch_chromium.org, chromium-reviews, Dirk Pranke
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add example cases in unit tests for tests with "Slow" expectations. This CL just expands the unit tests for: layout_test_results rebaseline_cl update_w3c_test_expectations: The purpose of this was to investigate http://crbug.com/676196 and see whether slow tests were not rebaselined as expected due to being treated differently than results with expected: "Pass" and actual: "Text". The result was that it appear that slow results should be handled as expected. This CL doesn't change behavior -- it just adds more test methods to unit tests. BUG=676196 Committed: https://crrev.com/b341f101e1123f2eb9c67c074d8c1a5036fc46b2 Cr-Commit-Position: refs/heads/master@{#441191}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -2 lines) Patch
M third_party/WebKit/Tools/Scripts/webkitpy/common/net/layout_test_results_unittest.py View 1 chunk +26 lines, -0 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_cl_unittest.py View 5 chunks +11 lines, -2 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/w3c/update_w3c_test_expectations_unittest.py View 1 chunk +24 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
qyearsley
3 years, 11 months ago (2016-12-28 20:08:16 UTC) #3
jeffcarp
lgtm
3 years, 11 months ago (2017-01-03 18:29:01 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2605103002/1
3 years, 11 months ago (2017-01-03 18:45:25 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
3 years, 11 months ago (2017-01-03 19:52:11 UTC) #9
commit-bot: I haz the power
3 years, 11 months ago (2017-01-03 19:54:42 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b341f101e1123f2eb9c67c074d8c1a5036fc46b2
Cr-Commit-Position: refs/heads/master@{#441191}

Powered by Google App Engine
This is Rietveld 408576698