Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1370)

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/common/net/layout_test_results_unittest.py

Issue 2605103002: Add example cases in unit tests for tests with "Slow" expectations. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_cl_unittest.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Tools/Scripts/webkitpy/common/net/layout_test_results_unittest.py
diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/common/net/layout_test_results_unittest.py b/third_party/WebKit/Tools/Scripts/webkitpy/common/net/layout_test_results_unittest.py
index f0ad5c0760f26f621671c0e2c18f3b0e6c73b1cf..d8f9daa5fd7dc800d3a03ac23cc41b65b57b56fe 100644
--- a/third_party/WebKit/Tools/Scripts/webkitpy/common/net/layout_test_results_unittest.py
+++ b/third_party/WebKit/Tools/Scripts/webkitpy/common/net/layout_test_results_unittest.py
@@ -130,3 +130,29 @@ class LayoutTestResultsTest(unittest.TestCase):
'fast/dom/prototype-taco.html',
'svg/dynamic-updates/SVGFEDropShadowElement-dom-stdDeviation-attr.html',
])
+
+ def test_didnt_run_as_expected_slow_test(self):
+ results = LayoutTestResults({
+ "tests": {
+ "fast": {
+ "dom": {
+ "prototype-fast.html": {
+ "expected": "PASS",
+ "actual": "TEXT",
+ "is_unexpected": True,
+ },
+ "prototype-slow.html": {
+ "expected": "SLOW",
+ "actual": "TEXT",
+ "is_unexpected": True,
+ }
+ }
+ }
+ }
+ })
+ self.assertEqual(
+ [r.test_name() for r in results.didnt_run_as_expected_results()],
+ [
+ 'fast/dom/prototype-fast.html',
+ 'fast/dom/prototype-slow.html',
+ ])
« no previous file with comments | « no previous file | third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_cl_unittest.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698