Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(799)

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_cl_unittest.py

Issue 2605103002: Add example cases in unit tests for tests with "Slow" expectations. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_cl_unittest.py
diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_cl_unittest.py b/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_cl_unittest.py
index d8b525028158b162bf864876649d0473392c12b5..bba548905d94f79393982d6b1a64e4e705f83565 100644
--- a/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_cl_unittest.py
+++ b/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_cl_unittest.py
@@ -92,7 +92,12 @@ class RebaselineCLTest(BaseTestCase, LoggingTestCase):
'actual': 'MISSING',
'is_unexpected': True,
'is_missing_text': True,
- }
+ },
+ 'prototype-slowtest.html': {
+ 'expected': 'SLOW',
+ 'actual': 'TEXT',
+ 'is_unexpected': True,
+ },
}
},
'svg': {
@@ -112,9 +117,10 @@ class RebaselineCLTest(BaseTestCase, LoggingTestCase):
self.tool.buildbot.set_retry_sumary_json(Build('MOCK Try Win', 5000), json.dumps({
'failures': [
+ 'fast/dom/prototype-inheritance.html',
'fast/dom/prototype-newtest.html',
+ 'fast/dom/prototype-slowtest.html',
'fast/dom/prototype-taco.html',
- 'fast/dom/prototype-inheritance.html',
'svg/dynamic-updates/SVGFEDropShadowElement-dom-stdDeviation-attr.html',
],
'ignored': [],
@@ -154,6 +160,7 @@ class RebaselineCLTest(BaseTestCase, LoggingTestCase):
self.assertLog([
'INFO: Rebaselining fast/dom/prototype-inheritance.html\n',
'INFO: Rebaselining fast/dom/prototype-newtest.html\n',
+ 'INFO: Rebaselining fast/dom/prototype-slowtest.html\n',
'INFO: Rebaselining fast/dom/prototype-taco.html\n',
'INFO: Rebaselining svg/dynamic-updates/SVGFEDropShadowElement-dom-stdDeviation-attr.html\n',
])
@@ -172,6 +179,7 @@ class RebaselineCLTest(BaseTestCase, LoggingTestCase):
self.assertLog([
'INFO: Rebaselining fast/dom/prototype-inheritance.html\n',
'INFO: Rebaselining fast/dom/prototype-newtest.html\n',
+ 'INFO: Rebaselining fast/dom/prototype-slowtest.html\n',
'INFO: Rebaselining fast/dom/prototype-taco.html\n',
'INFO: Rebaselining svg/dynamic-updates/SVGFEDropShadowElement-dom-stdDeviation-attr.html\n',
])
@@ -216,6 +224,7 @@ class RebaselineCLTest(BaseTestCase, LoggingTestCase):
'WARNING: No retry summary available for build Build(builder_name=u\'MOCK Try Win\', build_number=5000).\n',
'INFO: Rebaselining fast/dom/prototype-inheritance.html\n',
'INFO: Rebaselining fast/dom/prototype-newtest.html\n',
+ 'INFO: Rebaselining fast/dom/prototype-slowtest.html\n',
'INFO: Rebaselining fast/dom/prototype-taco.html\n',
'INFO: Rebaselining svg/dynamic-updates/SVGFEDropShadowElement-dom-stdDeviation-attr.html\n',
])

Powered by Google App Engine
This is Rietveld 408576698