[android] Disable NewApi lint warning when building with emma coverage enabled.

[android] Disable NewApi lint warning when building with emma coverage enabled.

EMMA coverage appears to mess with NewApi's ability to detect when an API is
being used within a conditional (see isWithinSdkConditional in
https://goo.gl/GJmTa9).

BUG=677320
Committed: https://crrev.com/cd908baa731d5b9c657b98f2e8025f1e4f48a5e5
Cr-Commit-Position: refs/heads/master@{#441132}

[jbudorick, 2016-12-28 20:20:17]

jbudorick@chromium.org changed reviewers:
+ agrieve@chromium.org

[agrieve, 2017-01-03 13:49:11]

lgtm

https://codereview.chromium.org/2605023003/diff/1/build/config/android/intern...
File build/config/android/internal_rules.gni (right):

https://codereview.chromium.org/2605023003/diff/1/build/config/android/intern...
build/config/android/internal_rules.gni:2485: if (_emma_instrument) {
nit: can you add a comment pointing to the bug here?

[jbudorick, 2017-01-03 14:04:56]

https://codereview.chromium.org/2605023003/diff/1/build/config/android/intern...
File build/config/android/internal_rules.gni (right):

https://codereview.chromium.org/2605023003/diff/1/build/config/android/intern...
build/config/android/internal_rules.gni:2485: if (_emma_instrument) {
On 2017/01/03 13:49:11, agrieve wrote:
> nit: can you add a comment pointing to the bug here?

Done.

[jbudorick, 2017-01-03 14:05:00]

The CQ bit was checked by jbudorick@chromium.org

[jbudorick, 2017-01-03 14:05:01]

The patchset sent to the CQ was uploaded after l-g-t-m from agrieve@chromium.org
Link to the patchset: https://codereview.chromium.org/2605023003/#ps20001
(title: "agrieve comment")

[commit-bot: I haz the power, 2017-01-03 14:05:11]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-03 16:19:51]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1483452300838720,
"parent_rev": "d2b1fc9ced7cfb3818f431461c108be7eabd75cb", "commit_rev":
"1cfe8f48fba299bfd7fd1a4a0188576c3d72b01c"}

[commit-bot: I haz the power, 2017-01-03 16:20:23]

Description was changed from

==========
[android] Disable NewApi lint warning when building with emma coverage enabled.

EMMA coverage appears to mess with NewApi's ability to detect when an API is
being used within a conditional (see isWithinSdkConditional in
https://goo.gl/GJmTa9).

BUG=677320
==========

to

==========
[android] Disable NewApi lint warning when building with emma coverage enabled.

EMMA coverage appears to mess with NewApi's ability to detect when an API is
being used within a conditional (see isWithinSdkConditional in
https://goo.gl/GJmTa9).

BUG=677320

Review-Url: https://codereview.chromium.org/2605023003
==========

[commit-bot: I haz the power, 2017-01-03 16:20:24]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2017-01-03 16:23:00]

Description was changed from

==========
[android] Disable NewApi lint warning when building with emma coverage enabled.

EMMA coverage appears to mess with NewApi's ability to detect when an API is
being used within a conditional (see isWithinSdkConditional in
https://goo.gl/GJmTa9).

BUG=677320

Review-Url: https://codereview.chromium.org/2605023003
==========

to

==========
[android] Disable NewApi lint warning when building with emma coverage enabled.

EMMA coverage appears to mess with NewApi's ability to detect when an API is
being used within a conditional (see isWithinSdkConditional in
https://goo.gl/GJmTa9).

BUG=677320

Committed: https://crrev.com/cd908baa731d5b9c657b98f2e8025f1e4f48a5e5
Cr-Commit-Position: refs/heads/master@{#441132}
==========

[commit-bot: I haz the power, 2017-01-03 16:23:01]

Patchset 2 (id:??) landed as
https://crrev.com/cd908baa731d5b9c657b98f2e8025f1e4f48a5e5
Cr-Commit-Position: refs/heads/master@{#441132}