Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1406)

Side by Side Diff: build/config/android/internal_rules.gni

Issue 2605023003: [android] Disable NewApi lint warning when building with emma coverage enabled. (Closed)
Patch Set: agrieve comment Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « build/android/gyp/lint.py ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # Do not add any imports to non-//build directories here. 5 # Do not add any imports to non-//build directories here.
6 # Some projects (e.g. V8) do not have non-build directories DEPS'ed in. 6 # Some projects (e.g. V8) do not have non-build directories DEPS'ed in.
7 import("//build_overrides/build.gni") 7 import("//build_overrides/build.gni")
8 import("//build/config/android/config.gni") 8 import("//build/config/android/config.gni")
9 import("//build/config/dcheck_always_on.gni") 9 import("//build/config/dcheck_always_on.gni")
10 import("//build/config/sanitizers/sanitizers.gni") 10 import("//build/config/sanitizers/sanitizers.gni")
(...skipping 671 matching lines...) Expand 10 before | Expand all | Expand 10 after
682 rebase_path(depfile, root_build_dir), 682 rebase_path(depfile, root_build_dir),
683 "--config-path", 683 "--config-path",
684 rebase_path(_suppressions_file, root_build_dir), 684 rebase_path(_suppressions_file, root_build_dir),
685 "--manifest-path", 685 "--manifest-path",
686 rebase_path(invoker.android_manifest, root_build_dir), 686 rebase_path(invoker.android_manifest, root_build_dir),
687 "--product-dir=.", 687 "--product-dir=.",
688 "--processed-config-path", 688 "--processed-config-path",
689 rebase_path(_config_path, root_build_dir), 689 rebase_path(_config_path, root_build_dir),
690 "--result-path", 690 "--result-path",
691 rebase_path(_result_path, root_build_dir), 691 rebase_path(_result_path, root_build_dir),
692 "--enable",
693 ] 692 ]
694 693
694 if (defined(invoker.disable)) {
695 args += [ "--disable=${invoker.disable}" ]
696 }
697
695 if (defined(invoker.create_cache) && invoker.create_cache) { 698 if (defined(invoker.create_cache) && invoker.create_cache) {
696 args += [ 699 args += [
697 "--create-cache", 700 "--create-cache",
698 "--silent", 701 "--silent",
699 ] 702 ]
700 } else { 703 } else {
701 inputs += invoker.java_files 704 inputs += invoker.java_files
702 inputs += [ 705 inputs += [
703 invoker.jar_path, 706 invoker.jar_path,
704 invoker.build_config, 707 invoker.build_config,
(...skipping 1767 matching lines...) Expand 10 before | Expand all | Expand 10 after
2472 _has_lint_target = true 2475 _has_lint_target = true
2473 android_lint("${_template_name}__lint") { 2476 android_lint("${_template_name}__lint") {
2474 android_manifest = _android_manifest 2477 android_manifest = _android_manifest
2475 build_config = _build_config 2478 build_config = _build_config
2476 jar_path = _jar_path 2479 jar_path = _jar_path
2477 java_files = _java_files 2480 java_files = _java_files
2478 if (_java_files != []) { 2481 if (_java_files != []) {
2479 java_sources_file = _java_sources_file 2482 java_sources_file = _java_sources_file
2480 } 2483 }
2481 deps = _accumulated_deps 2484 deps = _accumulated_deps
2485 if (_emma_instrument) {
2486 # Disable the NewApi lint warning when building with coverage
2487 # enabled. Coverage seems to mess with how the linter detects
2488 # the usages of a new API within a conditional. See
2489 # crbug.com/677320 for more.
2490 disable = [ "NewApi" ]
2491 }
2482 } 2492 }
2483 2493
2484 if (_run_findbugs) { 2494 if (_run_findbugs) {
2485 findbugs("${_template_name}__findbugs") { 2495 findbugs("${_template_name}__findbugs") {
2486 build_config = _build_config 2496 build_config = _build_config
2487 jar_path = _jar_path 2497 jar_path = _jar_path
2488 deps = _accumulated_deps 2498 deps = _accumulated_deps
2489 } 2499 }
2490 } 2500 }
2491 2501
(...skipping 313 matching lines...) Expand 10 before | Expand all | Expand 10 after
2805 rebase_path(root_build_dir, root_build_dir), 2815 rebase_path(root_build_dir, root_build_dir),
2806 "--packed-libraries-dir", 2816 "--packed-libraries-dir",
2807 rebase_path(_packed_libraries_dir, root_build_dir), 2817 rebase_path(_packed_libraries_dir, root_build_dir),
2808 "--libraries=${invoker.libraries_filearg}", 2818 "--libraries=${invoker.libraries_filearg}",
2809 "--filelistjson", 2819 "--filelistjson",
2810 rebase_path(invoker.file_list_json, root_build_dir), 2820 rebase_path(invoker.file_list_json, root_build_dir),
2811 ] 2821 ]
2812 } 2822 }
2813 } 2823 }
2814 } 2824 }
OLDNEW
« no previous file with comments | « build/android/gyp/lint.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698