Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Issue 2604673002: Revert of [heap] Report wrappers after processing the marking deque incrementally (Closed)

Created:
3 years, 12 months ago by Michael Achenbach
Modified:
3 years, 12 months ago
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [heap] Report wrappers after processing the marking deque incrementally (patchset #5 id:80001 of https://codereview.chromium.org/2604583002/ ) Reason for revert: Speculative revert. Might block the roll: https://codereview.chromium.org/2606503002/ The gpu bots crash with this stack top:v88internal18IncrementalMarking25AdvanceIncrementalMarkingEdNS1_16CompletionActionENS1_21ForceCompletionActionENS0_10StepOrigin Original issue's description: > [heap] Report wrappers after processing the marking deque incrementally > > BUG=chromium:676700, chromium:468240 > > Review-Url: https://codereview.chromium.org/2604583002 > Cr-Commit-Position: refs/heads/master@{#41946} > Committed: https://chromium.googlesource.com/v8/v8/+/1344e3a9caba4206758623630e3c3dd6872879e7 TBR=hpayer@chromium.org,mlippautz@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:676700, chromium:468240 Review-Url: https://codereview.chromium.org/2604673002 Cr-Commit-Position: refs/heads/master@{#41951} Committed: https://chromium.googlesource.com/v8/v8/+/061a3a152ce4ac2a1aaf8efcc4207246cfb9ed1e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -11 lines) Patch
M src/heap/embedder-tracing.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/heap/incremental-marking.cc View 2 chunks +0 lines, -7 lines 0 comments Download
M src/heap/mark-compact.cc View 1 chunk +0 lines, -1 line 0 comments Download
M test/unittests/heap/embedder-tracing-unittest.cc View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Michael Achenbach
Created Revert of [heap] Report wrappers after processing the marking deque incrementally
3 years, 12 months ago (2016-12-24 12:07:16 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2604673002/1
3 years, 12 months ago (2016-12-24 12:07:25 UTC) #3
commit-bot: I haz the power
3 years, 12 months ago (2016-12-24 12:07:41 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/061a3a152ce4ac2a1aaf8efcc4207246cfb...

Powered by Google App Engine
This is Rietveld 408576698