test/unittests/heap/embedder-tracing-unittest.cc - Issue 2604673002: Revert of [heap] Report wrappers after processing the marking deque incrementally

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/unittests/heap/embedder-tracing-unittest.cc

Issue 2604673002: Revert of [heap] Report wrappers after processing the marking deque incrementally (Closed)

Patch Set: Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: test/unittests/heap/embedder-tracing-unittest.cc

diff --git a/test/unittests/heap/embedder-tracing-unittest.cc b/test/unittests/heap/embedder-tracing-unittest.cc

index e6a6f2e250b117d951070b376de511c055921303..5e53177238284afef6332ef8962d18cc52d3caea 100644

--- a/test/unittests/heap/embedder-tracing-unittest.cc

+++ b/test/unittests/heap/embedder-tracing-unittest.cc

@@ -135,7 +135,6 @@

local_tracer.AddWrapperToTrace(CreateWrapperInfo());

EXPECT_EQ(1u, local_tracer.NumberOfCachedWrappersToTrace());

EXPECT_CALL(remote_tracer, RegisterV8References(_));

- local_tracer.RegisterWrappersWithRemoteTracer();

EXPECT_CALL(remote_tracer, AdvanceTracing(0, _)).WillOnce(Return(false));

EXPECT_FALSE(local_tracer.Trace(

0, EmbedderHeapTracer::AdvanceTracingActions(

@@ -150,7 +149,6 @@

local_tracer.AddWrapperToTrace(CreateWrapperInfo());

EXPECT_EQ(1u, local_tracer.NumberOfCachedWrappersToTrace());

EXPECT_CALL(remote_tracer, RegisterV8References(_));

- local_tracer.RegisterWrappersWithRemoteTracer();

EXPECT_CALL(remote_tracer, AdvanceTracing(0, _)).WillOnce(Return(true));

EXPECT_TRUE(local_tracer.Trace(

0, EmbedderHeapTracer::AdvanceTracingActions(

« no previous file with comments | « src/heap/mark-compact.cc ('k') | no next file » | no next file with comments »