[heap] Report wrappers after processing the marking deque incrementally

[heap] Report wrappers after processing the marking deque incrementally

BUG=chromium:676700, chromium:468240
Review-Url: https://codereview.chromium.org/2604583002
Cr-Commit-Position: refs/heads/master@{#41946}
Committed: https://chromium.googlesource.com/v8/v8/+/1344e3a9caba4206758623630e3c3dd6872879e7

[Michael Lippautz, 2016-12-23 12:42:39]

Description was changed from

==========
[heap] Report wrappers after processing the marking deque incrementally

BUG=
==========

to

==========
[heap] Report wrappers after processing the marking deque incrementally

BUG=chromium:676700, chromium:468240
==========

[Michael Lippautz, 2016-12-23 12:42:39]

mlippautz@chromium.org changed reviewers:
+ hpayer@chromium.org

[Hannes Payer (out of office), 2016-12-23 13:03:25]

1) I am wondering if we can get rid of the call
RegisterWrappersWithRemoteTracer(); in LocalEmbedderHeapTracer::Trace.

2) Can we add DCHECKs everywhere the main thread enters which checks that there
are no cached wrappers. Let's also document that invariant somewhere.

[Michael Lippautz, 2016-12-23 13:08:14]

On 2016/12/23 13:03:25, Hannes Payer wrote:
> 1) I am wondering if we can get rid of the call
> RegisterWrappersWithRemoteTracer(); in LocalEmbedderHeapTracer::Trace.
> 

Potentially, yes. We would need to register then explicitly when called in the
atomic pause.

> 2) Can we add DCHECKs everywhere the main thread enters which checks that
there
> are no cached wrappers. Let's also document that invariant somewhere.

I added a DCHECK to AdvanceIncrementalMarking, which is the entry point for
incremental marking. If this DCHECK fires we somehow missed to register on
another path.

[Michael Lippautz, 2016-12-23 13:08:37]

The CQ bit was checked by mlippautz@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-23 13:08:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-23 13:34:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-23 13:34:04]

Dry run: This issue passed the CQ dry run.

[Michael Lippautz, 2016-12-23 13:39:46]

The CQ bit was checked by mlippautz@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-23 13:39:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Hannes Payer (out of office), 2016-12-23 13:45:54]

lgtm

[Michael Lippautz, 2016-12-23 13:46:44]

The CQ bit was checked by mlippautz@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-23 13:46:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-23 14:00:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-23 14:00:45]

Dry run: Try jobs failed on following builders:
  v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/build...)
  v8_linux64_gyp_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng_trigg...)

[Michael Lippautz, 2016-12-23 14:01:55]

The CQ bit was checked by mlippautz@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-23 14:02:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-23 14:25:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-23 14:25:56]

Dry run: This issue passed the CQ dry run.

[Michael Lippautz, 2016-12-23 15:28:48]

The CQ bit was checked by mlippautz@chromium.org

[Michael Lippautz, 2016-12-23 15:28:48]

The patchset sent to the CQ was uploaded after l-g-t-m from hpayer@chromium.org
Link to the patchset: https://codereview.chromium.org/2604583002/#ps80001
(title: "Fix test")

[commit-bot: I haz the power, 2016-12-23 15:28:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-23 17:11:43]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1482506928041170,
"parent_rev": "8c1397e4a0459450fa3787286634c512294d67c0", "commit_rev":
"1344e3a9caba4206758623630e3c3dd6872879e7"}

[commit-bot: I haz the power, 2016-12-23 17:11:48]

Description was changed from

==========
[heap] Report wrappers after processing the marking deque incrementally

BUG=chromium:676700, chromium:468240
==========

to

==========
[heap] Report wrappers after processing the marking deque incrementally

BUG=chromium:676700, chromium:468240

Review-Url: https://codereview.chromium.org/2604583002
Cr-Commit-Position: refs/heads/master@{#41946}
Committed:
https://chromium.googlesource.com/v8/v8/+/1344e3a9caba4206758623630e3c3dd6872...
==========

[commit-bot: I haz the power, 2016-12-23 17:11:49]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/v8/v8/+/1344e3a9caba4206758623630e3c3dd6872...

[Michael Achenbach, 2016-12-24 12:07:16]

A revert of this CL (patchset #5 id:80001) has been created in
https://codereview.chromium.org/2604673002/ by machenbach@chromium.org.

The reason for reverting is: Speculative revert. Might block the roll:
https://codereview.chromium.org/2606503002/

The gpu bots crash with this stack
top:v88internal18IncrementalMarking25AdvanceIncrementalMarkingEdNS1_16CompletionActionENS1_21ForceCompletionActionENS0_10StepOrigin.