Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Issue 2604123002: Created test for window.history.pushState(). (Closed)

Created:
3 years, 11 months ago by kkhorimoto
Modified:
3 years, 11 months ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Created test for window.history.pushState(). BUG=673022 Review-Url: https://codereview.chromium.org/2604123002 Cr-Commit-Position: refs/heads/master@{#445968} Committed: https://chromium.googlesource.com/chromium/src/+/99d6b7f8f877750caa5654d2c62594b3761fd1ad

Patch Set 1 #

Patch Set 2 : rebase + eugene's comments #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -0 lines) Patch
M ios/web/navigation/history_state_operations_inttest.mm View 1 1 chunk +31 lines, -0 lines 1 comment Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 14 (6 generated)
kkhorimoto
3 years, 11 months ago (2016-12-29 04:03:08 UTC) #2
kkhorimoto
rebase + eugene's comments
3 years, 11 months ago (2017-01-24 05:29:38 UTC) #3
kkhorimoto
Fixed common critiques of my other CLs
3 years, 11 months ago (2017-01-24 05:30:11 UTC) #4
Eugene But (OOO till 7-30)
lgtm https://codereview.chromium.org/2604123002/diff/20001/ios/web/navigation/history_state_operations_inttest.mm File ios/web/navigation/history_state_operations_inttest.mm (right): https://codereview.chromium.org/2604123002/diff/20001/ios/web/navigation/history_state_operations_inttest.mm#newcode352 ios/web/navigation/history_state_operations_inttest.mm:352: ExecuteBlockAndWaitForLoad(state_operations_url(), ^{ Not related to this CL, but ...
3 years, 11 months ago (2017-01-24 19:26:38 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2604123002/20001
3 years, 11 months ago (2017-01-24 23:44:40 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_chromium_compile_only_ng/builds/270444)
3 years, 11 months ago (2017-01-25 03:47:34 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2604123002/20001
3 years, 11 months ago (2017-01-25 06:11:36 UTC) #11
commit-bot: I haz the power
3 years, 11 months ago (2017-01-25 06:18:08 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/99d6b7f8f877750caa5654d2c625...

Powered by Google App Engine
This is Rietveld 408576698