Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(289)

Issue 2606653002: Files app: Move common/js/externs.js to externs/*. (Closed)

Created:
3 years, 12 months ago by fukino
Modified:
3 years, 12 months ago
Reviewers:
oka
CC:
chromium-reviews, yamaguchi+watch_chromium.org, oka+watch_chromium.org, rginda+watch_chromium.org, mtomasz+watch_chromium.org, jlklein+watch-closure_chromium.org, fukino+watch_chromium.org, vitalyp+closure_chromium.org, dbeam+watch-closure_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Files app: Move common/js/externs.js to externs/*. BUG=636289 TEST=run third_party/closure_compiler/run_compiler CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/c5b094e5fcc2c975659de1fc24b7b5190abd9bf0 Cr-Commit-Position: refs/heads/master@{#440700}

Patch Set 1 #

Total comments: 2

Patch Set 2 : --similarity=20 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -266 lines) Patch
M ui/file_manager/compiled_resources2.gyp View 1 chunk +1 line, -0 lines 0 comments Download
A + ui/file_manager/externs/background_window.js View 1 2 chunks +2 lines, -46 lines 1 comment Download
M ui/file_manager/externs/compiled_resources2.gyp View 3 chunks +16 lines, -0 lines 0 comments Download
A + ui/file_manager/externs/directory_change_event.js View 1 2 chunks +2 lines, -55 lines 0 comments Download
A ui/file_manager/externs/entries_changed_event.js View 1 chunk +15 lines, -0 lines 0 comments Download
A + ui/file_manager/externs/file_operation_progress_event.js View 1 2 chunks +2 lines, -59 lines 0 comments Download
M ui/file_manager/file_manager/background/js/compiled_resources.gyp View 1 chunk +1 line, -1 line 0 comments Download
M ui/file_manager/file_manager/common/js/compiled_resources2.gyp View 1 chunk +16 lines, -32 lines 0 comments Download
D ui/file_manager/file_manager/common/js/externs.js View 1 chunk +0 lines, -72 lines 0 comments Download
M ui/file_manager/file_manager/common/js/lru_cache_unittest.js View 1 chunk +1 line, -0 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/compiled_resources.gyp View 2 chunks +3 lines, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 17 (8 generated)
fukino
3 years, 12 months ago (2016-12-26 08:04:19 UTC) #3
oka
LGTM with nits. Nit: common/externs -> common/js/externs.js in description? https://codereview.chromium.org/2606653002/diff/1/ui/file_manager/externs/background_window.js File ui/file_manager/externs/background_window.js (right): https://codereview.chromium.org/2606653002/diff/1/ui/file_manager/externs/background_window.js#newcode1 ui/file_manager/externs/background_window.js:1: ...
3 years, 12 months ago (2016-12-26 08:13:06 UTC) #4
fukino
Thanks! updated the description. https://codereview.chromium.org/2606653002/diff/1/ui/file_manager/externs/background_window.js File ui/file_manager/externs/background_window.js (right): https://codereview.chromium.org/2606653002/diff/1/ui/file_manager/externs/background_window.js#newcode1 ui/file_manager/externs/background_window.js:1: // Copyright 2016 The Chromium ...
3 years, 12 months ago (2016-12-26 08:28:15 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2606653002/20001
3 years, 12 months ago (2016-12-26 08:28:25 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
3 years, 12 months ago (2016-12-26 08:54:59 UTC) #12
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/c5b094e5fcc2c975659de1fc24b7b5190abd9bf0 Cr-Commit-Position: refs/heads/master@{#440700}
3 years, 12 months ago (2016-12-26 08:58:08 UTC) #14
oka
https://codereview.chromium.org/2606653002/diff/20001/ui/file_manager/externs/background_window.js File ui/file_manager/externs/background_window.js (right): https://codereview.chromium.org/2606653002/diff/20001/ui/file_manager/externs/background_window.js#newcode1 ui/file_manager/externs/background_window.js:1: // Copyright 2016 The Chromium Authors. All rights reserved. ...
3 years, 12 months ago (2016-12-26 10:14:59 UTC) #15
fukino
On 2016/12/26 10:14:59, oka wrote: > https://codereview.chromium.org/2606653002/diff/20001/ui/file_manager/externs/background_window.js > File ui/file_manager/externs/background_window.js (right): > > https://codereview.chromium.org/2606653002/diff/20001/ui/file_manager/externs/background_window.js#newcode1 > ...
3 years, 12 months ago (2016-12-26 10:24:35 UTC) #16
oka
3 years, 12 months ago (2016-12-26 10:34:04 UTC) #17
Message was sent while issue was closed.
Thanks!

On Mon, Dec 26, 2016 at 7:24 PM <fukino@chromium.org> wrote:

> On 2016/12/26 10:14:59, oka wrote:
> >
>
>
https://codereview.chromium.org/2606653002/diff/20001/ui/file_manager/externs...
> > File ui/file_manager/externs/background_window.js (right):
> >
> >
>
>
https://codereview.chromium.org/2606653002/diff/20001/ui/file_manager/externs...
> > ui/file_manager/externs/background_window.js:1: // Copyright 2016 The
> Chromium
> > Authors. All rights reserved.
> > Belated, but did we decide not to use @externs?
>
> AFAIK, we don't have any explicit rule for file-level annotation like
> @externs,
> @fileoverview, ....
>
> https://codereview.chromium.org/2606653002/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

Powered by Google App Engine
This is Rietveld 408576698