Files app: Move common/js/externs.js to externs/*.

Files app: Move common/js/externs.js to externs/*.

BUG=636289
TEST=run third_party/closure_compiler/run_compiler
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/c5b094e5fcc2c975659de1fc24b7b5190abd9bf0
Cr-Commit-Position: refs/heads/master@{#440700}

[fukino, 2016-12-26 08:03:21]

Description was changed from

==========
Files app: Move common/externs to externs/*.

BUG=636289
TEST=run third_party/closure_compiler/run_compiler
==========

to

==========
Files app: Move common/externs to externs/*.

BUG=636289
TEST=run third_party/closure_compiler/run_compiler
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[fukino, 2016-12-26 08:04:18]

fukino@chromium.org changed reviewers:
+ oka@chromium.org

[oka, 2016-12-26 08:13:06]

LGTM with nits.
Nit: common/externs -> common/js/externs.js in description?

https://codereview.chromium.org/2606653002/diff/1/ui/file_manager/externs/bac...
File ui/file_manager/externs/background_window.js (right):

https://codereview.chromium.org/2606653002/diff/1/ui/file_manager/externs/bac...
ui/file_manager/externs/background_window.js:1: // Copyright 2016 The Chromium
Authors. All rights reserved.
nit: You may want to set similarity=20 or something on git cl upload so that
it's detected that this code is moved from externs.js.

[fukino, 2016-12-26 08:25:32]

Description was changed from

==========
Files app: Move common/externs to externs/*.

BUG=636289
TEST=run third_party/closure_compiler/run_compiler
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Files app: Move common/js/externs.js to externs/*.

BUG=636289
TEST=run third_party/closure_compiler/run_compiler
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[fukino, 2016-12-26 08:28:15]

Thanks! updated the description.

https://codereview.chromium.org/2606653002/diff/1/ui/file_manager/externs/bac...
File ui/file_manager/externs/background_window.js (right):

https://codereview.chromium.org/2606653002/diff/1/ui/file_manager/externs/bac...
ui/file_manager/externs/background_window.js:1: // Copyright 2016 The Chromium
Authors. All rights reserved.
On 2016/12/26 08:13:05, oka wrote:
> nit: You may want to set similarity=20 or something on git cl upload so that
> it's detected that this code is moved from externs.js.

Done.

[fukino, 2016-12-26 08:28:19]

The CQ bit was checked by fukino@chromium.org

[fukino, 2016-12-26 08:28:19]

The patchset sent to the CQ was uploaded after l-g-t-m from oka@chromium.org
Link to the patchset: https://codereview.chromium.org/2606653002/#ps20001
(title: "--similarity=20")

[commit-bot: I haz the power, 2016-12-26 08:28:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-26 08:54:31]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1482740899124930,
"parent_rev": "2bf5f0e6462b2a79bc2f09c104a783e67cebff77", "commit_rev":
"2872896e6546ba0f872e5db8d1670cad13c1ea60"}

[commit-bot: I haz the power, 2016-12-26 08:54:58]

Description was changed from

==========
Files app: Move common/js/externs.js to externs/*.

BUG=636289
TEST=run third_party/closure_compiler/run_compiler
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Files app: Move common/js/externs.js to externs/*.

BUG=636289
TEST=run third_party/closure_compiler/run_compiler
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2606653002
==========

[commit-bot: I haz the power, 2016-12-26 08:54:59]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-12-26 08:58:07]

Description was changed from

==========
Files app: Move common/js/externs.js to externs/*.

BUG=636289
TEST=run third_party/closure_compiler/run_compiler
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2606653002
==========

to

==========
Files app: Move common/js/externs.js to externs/*.

BUG=636289
TEST=run third_party/closure_compiler/run_compiler
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/c5b094e5fcc2c975659de1fc24b7b5190abd9bf0
Cr-Commit-Position: refs/heads/master@{#440700}
==========

[commit-bot: I haz the power, 2016-12-26 08:58:08]

Patchset 2 (id:??) landed as
https://crrev.com/c5b094e5fcc2c975659de1fc24b7b5190abd9bf0
Cr-Commit-Position: refs/heads/master@{#440700}

[oka, 2016-12-26 10:14:59]

https://codereview.chromium.org/2606653002/diff/20001/ui/file_manager/externs...
File ui/file_manager/externs/background_window.js (right):

https://codereview.chromium.org/2606653002/diff/20001/ui/file_manager/externs...
ui/file_manager/externs/background_window.js:1: // Copyright 2016 The Chromium
Authors. All rights reserved.
Belated, but did we decide not to use @externs?

[fukino, 2016-12-26 10:24:35]

On 2016/12/26 10:14:59, oka wrote:
>
https://codereview.chromium.org/2606653002/diff/20001/ui/file_manager/externs...
> File ui/file_manager/externs/background_window.js (right):
> 
>
https://codereview.chromium.org/2606653002/diff/20001/ui/file_manager/externs...
> ui/file_manager/externs/background_window.js:1: // Copyright 2016 The Chromium
> Authors. All rights reserved.
> Belated, but did we decide not to use @externs?

AFAIK, we don't have any explicit rule for file-level annotation like @externs,
@fileoverview, ....

[oka, 2016-12-26 10:34:04]

Thanks!

On Mon, Dec 26, 2016 at 7:24 PM <fukino@chromium.org> wrote:

> On 2016/12/26 10:14:59, oka wrote:
> >
>
>
https://codereview.chromium.org/2606653002/diff/20001/ui/file_manager/externs...
> > File ui/file_manager/externs/background_window.js (right):
> >
> >
>
>
https://codereview.chromium.org/2606653002/diff/20001/ui/file_manager/externs...
> > ui/file_manager/externs/background_window.js:1: // Copyright 2016 The
> Chromium
> > Authors. All rights reserved.
> > Belated, but did we decide not to use @externs?
>
> AFAIK, we don't have any explicit rule for file-level annotation like
> @externs,
> @fileoverview, ....
>
> https://codereview.chromium.org/2606653002/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.