Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2603573002:
Support no-compile tests on Mac (Closed)
DescriptionSupport no-compile tests on Mac
The expected error message on Mac is:
fatal error: call to implicitly-deleted copy constructor
On Linux, it's:
fatal error: call to deleted constructor
BUG=676800
Committed: https://crrev.com/e1a7b9b88e0e16e81184f62970550a1080b02674
Cr-Commit-Position: refs/heads/master@{#441363}
Patch Set 1 : Support no-compile tests on Mac #
Total comments: 2
Patch Set 2 : precise match #
Depends on Patchset: Dependent Patchsets: Messages
Total messages: 17 (8 generated)
Patchset #1 (id:1) has been deleted
Description was changed from ========== Support no-compile tests on Mac The expected error message on Mac is: fatal error: call to implicitly-deleted copy constructor On Linux, it's: fatal error: call to deleted constructor BUG=676800 ========== to ========== Support no-compile tests on Mac The expected error message on Mac is: fatal error: call to implicitly-deleted copy constructor On Linux, it's: fatal error: call to deleted constructor BUG=676800 ==========
wychen@chromium.org changed reviewers: + dcheng@chromium.org
PTAL
Can you include the full text of the error? I'm a little surprised at the difference in error messages: I think we version clang on both Mac and Linux.
On 2016/12/24 01:03:31, dcheng wrote:
> Can you include the full text of the error? I'm a little surprised at the
> difference in error messages: I think we version clang on both Mac and Linux.
Ah. I found what makes them different.
There's an "include" directory on Mac, but not on Linux in this path:
third_party/llvm-build/Release+Asserts/include
The error message is:
On linux:
../../build/linux/debian_wheezy_amd64-sysroot/usr/lib/gcc/x86_64-linux-gnu/4.6/../../../../include/c++/4.6/bits/unique_ptr.h:256:7:
note: 'unique_ptr' has been explicitly marked deleted here
unique_ptr(const unique_ptr&) = delete;
^
On Mac:
../../third_party/llvm-build/Release+Asserts/bin/../include/c++/v1/memory:2482:31:
note: copy constructor is implicitly deleted because 'unique_ptr<base::Foo,
std::__1::default_delete<base::Foo> >' has a user-declared move constructor
_LIBCPP_INLINE_VISIBILITY unique_ptr(unique_ptr&& __u) _NOEXCEPT
^
LGTM with nit https://codereview.chromium.org/2603573002/diff/20001/base/callback_list_unit... File base/callback_list_unittest.nc (right): https://codereview.chromium.org/2603573002/diff/20001/base/callback_list_unit... base/callback_list_unittest.nc:38: #if defined(NCTEST_MOVE_ONLY_TYPE_PARAMETER) // [r"fatal error: call to [^ ]*deleted .*constructor"] Can we make this match precise? "call to (implicitly-)?deleted (copy )? constructor"
https://codereview.chromium.org/2603573002/diff/20001/base/callback_list_unit... File base/callback_list_unittest.nc (right): https://codereview.chromium.org/2603573002/diff/20001/base/callback_list_unit... base/callback_list_unittest.nc:38: #if defined(NCTEST_MOVE_ONLY_TYPE_PARAMETER) // [r"fatal error: call to [^ ]*deleted .*constructor"] On 2016/12/27 04:58:33, dcheng wrote: > Can we make this match precise? > "call to (implicitly-)?deleted (copy )? constructor" Done.
Trybot results are here: https://codereview.chromium.org/2603753002/#ps1
The CQ bit was checked by wychen@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from dcheng@chromium.org Link to the patchset: https://codereview.chromium.org/2603573002/#ps40001 (title: "precise match")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1483535525900900,
"parent_rev": "01b2aadf73a5f50a6b4940108917f15e658e7f26", "commit_rev":
"4c0c514281e0d5ccfecad158a8f965068f705c42"}
Message was sent while issue was closed.
Description was changed from ========== Support no-compile tests on Mac The expected error message on Mac is: fatal error: call to implicitly-deleted copy constructor On Linux, it's: fatal error: call to deleted constructor BUG=676800 ========== to ========== Support no-compile tests on Mac The expected error message on Mac is: fatal error: call to implicitly-deleted copy constructor On Linux, it's: fatal error: call to deleted constructor BUG=676800 Review-Url: https://codereview.chromium.org/2603573002 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== Support no-compile tests on Mac The expected error message on Mac is: fatal error: call to implicitly-deleted copy constructor On Linux, it's: fatal error: call to deleted constructor BUG=676800 Review-Url: https://codereview.chromium.org/2603573002 ========== to ========== Support no-compile tests on Mac The expected error message on Mac is: fatal error: call to implicitly-deleted copy constructor On Linux, it's: fatal error: call to deleted constructor BUG=676800 Committed: https://crrev.com/e1a7b9b88e0e16e81184f62970550a1080b02674 Cr-Commit-Position: refs/heads/master@{#441363} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/e1a7b9b88e0e16e81184f62970550a1080b02674 Cr-Commit-Position: refs/heads/master@{#441363} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
