Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2603753002:
Enable no-compile tests on Mac and iOS clang (Closed)
DescriptionEnable no-compile tests on Mac and iOS clang
BUG=105388
Review-Url: https://codereview.chromium.org/2603753002
Cr-Commit-Position: refs/heads/master@{#453317}
Committed: https://chromium.googlesource.com/chromium/src/+/09ac3a21d0b908ca26d0898f58ea77be7e9462d2
Patch Set 1 #Patch Set 2 : rebase #Patch Set 3 : rebase #Patch Set 4 : enable for ios as well #Messages
Total messages: 29 (23 generated)
The CQ bit was checked by wychen@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== Enable no-compile tests on Mac clang BUG=105388 ========== to ========== Enable no-compile tests on Mac clang BUG=105388 ==========
The CQ bit was checked by wychen@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
wychen@chromium.org changed reviewers: + dcheng@chromium.org, thakis@chromium.org
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
PTAL
On 2017/01/04 14:50:44, wychen wrote: > PTAL LGTM
The CQ bit was checked by wychen@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by wychen@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
thakis@, do you want to expand the coverage?
Description was changed from ========== Enable no-compile tests on Mac clang BUG=105388 ========== to ========== Enable no-compile tests on Mac and iOS clang BUG=105388 ==========
lgtm
The CQ bit was checked by wychen@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from dcheng@chromium.org Link to the patchset: https://codereview.chromium.org/2603753002/#ps60001 (title: "enable for ios as well")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 60001, "attempt_start_ts": 1488222193560620,
"parent_rev": "f0c242bac6c0a6cf422b637b6224da3d8ac5eb4c", "commit_rev":
"09ac3a21d0b908ca26d0898f58ea77be7e9462d2"}
Message was sent while issue was closed.
Description was changed from ========== Enable no-compile tests on Mac and iOS clang BUG=105388 ========== to ========== Enable no-compile tests on Mac and iOS clang BUG=105388 Review-Url: https://codereview.chromium.org/2603753002 Cr-Commit-Position: refs/heads/master@{#453317} Committed: https://chromium.googlesource.com/chromium/src/+/09ac3a21d0b908ca26d0898f58ea... ==========
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as https://chromium.googlesource.com/chromium/src/+/09ac3a21d0b908ca26d0898f58ea... |
