Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2595413004:
Fix no-compile tests on Linux by adding sysroot (Closed)
DescriptionFix no-compile tests on Linux by adding sysroot
It became necessary to specify sysroot after the following CL:
https://codereview.chromium.org/2583353002
Otherwise, std::is_trivially_copyable wouldn't be there.
This CL also fixes the missing header issue on Mac.
BUG=105388, 676800
Committed: https://crrev.com/296d75bd21e5f6b3d492dbec0f14dc22d837bf0b
Cr-Commit-Position: refs/heads/master@{#441327}
Patch Set 1 #
Dependent Patchsets: Messages
Total messages: 31 (15 generated)
Description was changed from ========== Fix no-compile tests on Linux by adding sysroot It becomes necessary to specify sysroot after the following CL: https://codereview.chromium.org/2583353002 Otherwise, std::is_trivially_copyable wouldn't be there. BUG=105388 ========== to ========== Fix no-compile tests on Linux by adding sysroot It becomes necessary to specify sysroot after the following CL: https://codereview.chromium.org/2583353002 Otherwise, std::is_trivially_copyable wouldn't be there. BUG=105388 ==========
wychen@chromium.org changed reviewers: + danakj@chromium.org, dcheng@chromium.org
Patchset #2 (id:20001) has been deleted
PTAL
Description was changed from ========== Fix no-compile tests on Linux by adding sysroot It becomes necessary to specify sysroot after the following CL: https://codereview.chromium.org/2583353002 Otherwise, std::is_trivially_copyable wouldn't be there. BUG=105388 ========== to ========== Fix no-compile tests on Linux by adding sysroot It becomes necessary to specify sysroot after the following CL: https://codereview.chromium.org/2583353002 Otherwise, std::is_trivially_copyable wouldn't be there. This also fixes the missing header issue on Mac. BUG=105388 ==========
Description was changed from ========== Fix no-compile tests on Linux by adding sysroot It becomes necessary to specify sysroot after the following CL: https://codereview.chromium.org/2583353002 Otherwise, std::is_trivially_copyable wouldn't be there. This also fixes the missing header issue on Mac. BUG=105388 ========== to ========== Fix no-compile tests on Linux by adding sysroot It becomes necessary to specify sysroot after the following CL: https://codereview.chromium.org/2583353002 Otherwise, std::is_trivially_copyable wouldn't be there. This also fixes the missing header issue on Mac. BUG=105388, 676800 ==========
Please refer to https://codereview.chromium.org/2599243002/#ps40001 for trybot results.
Description was changed from ========== Fix no-compile tests on Linux by adding sysroot It becomes necessary to specify sysroot after the following CL: https://codereview.chromium.org/2583353002 Otherwise, std::is_trivially_copyable wouldn't be there. This also fixes the missing header issue on Mac. BUG=105388, 676800 ========== to ========== Fix no-compile tests on Linux by adding sysroot It became necessary to specify sysroot after the following CL: https://codereview.chromium.org/2583353002 Otherwise, std::is_trivially_copyable wouldn't be there. This CL also fixes the missing header issue on Mac. BUG=105388, 676800 ==========
lgtm
The CQ bit was checked by wychen@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
wychen@chromium.org changed reviewers: + thakis@chromium.org
+Nico: PTAL after you come back. Thank you!
LGTM
The CQ bit was checked by danakj@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
lgtm (still think turning these on is a good idea?)
This won't help with the mac bug I think btw. For that you need an isysroot somewhere, like in https://cs.chromium.org/chromium/src/build/config/mac/BUILD.gn?q=isysroot+fil... On Tue, Jan 3, 2017 at 12:30 PM, <thakis@chromium.org> wrote: > lgtm > > (still think turning these on is a good idea?) > > https://codereview.chromium.org/2595413004/ > -- You received this message because you are subscribed to the Google Groups "Chromium-reviews" group. To unsubscribe from this group and stop receiving emails from it, send an email to chromium-reviews+unsubscribe@chromium.org.
The CQ bit was checked by wychen@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
On 2017/01/03 17:30:06, Nico (ooo sick) wrote: > lgtm > > (still think turning these on is a good idea?) Well, there are more roadblockers than my initial guesstimate, but so far I still think it's worth it. Let's see how it goes this round.
On 2017/01/03 17:31:05, Nico (ooo sick) wrote: > This won't help with the mac bug I think btw. For that you need an isysroot > somewhere, like in > https://cs.chromium.org/chromium/src/build/config/mac/BUILD.gn?q=isysroot+fil... I thought so as well, and I had another CL to add isysroot for the missing header problem on Mac. However, surprisingly this CL can fix the missing header problem as well, so I picked this one over the mac-only solution. It seems -isysroot on Mac is equivalent to --sysroot on other arch, according to: https://gcc.gnu.org/onlinedocs/gcc/Directory-Options.html
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1483509233289110, "parent_rev":
"696e3af162dd3338f227a87e1164a07fba26f1fa", "commit_rev":
"7477dd0d66e27e9a749f9a125abadf014498b362"}
Message was sent while issue was closed.
Description was changed from ========== Fix no-compile tests on Linux by adding sysroot It became necessary to specify sysroot after the following CL: https://codereview.chromium.org/2583353002 Otherwise, std::is_trivially_copyable wouldn't be there. This CL also fixes the missing header issue on Mac. BUG=105388, 676800 ========== to ========== Fix no-compile tests on Linux by adding sysroot It became necessary to specify sysroot after the following CL: https://codereview.chromium.org/2583353002 Otherwise, std::is_trivially_copyable wouldn't be there. This CL also fixes the missing header issue on Mac. BUG=105388, 676800 Review-Url: https://codereview.chromium.org/2595413004 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Fix no-compile tests on Linux by adding sysroot It became necessary to specify sysroot after the following CL: https://codereview.chromium.org/2583353002 Otherwise, std::is_trivially_copyable wouldn't be there. This CL also fixes the missing header issue on Mac. BUG=105388, 676800 Review-Url: https://codereview.chromium.org/2595413004 ========== to ========== Fix no-compile tests on Linux by adding sysroot It became necessary to specify sysroot after the following CL: https://codereview.chromium.org/2583353002 Otherwise, std::is_trivially_copyable wouldn't be there. This CL also fixes the missing header issue on Mac. BUG=105388, 676800 Committed: https://crrev.com/296d75bd21e5f6b3d492dbec0f14dc22d837bf0b Cr-Commit-Position: refs/heads/master@{#441327} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/296d75bd21e5f6b3d492dbec0f14dc22d837bf0b Cr-Commit-Position: refs/heads/master@{#441327} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
