Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 26031002: cc: Remove unused metrics from RenderingStats. (Closed)

Created:
7 years, 2 months ago by ernstm
Modified:
7 years, 2 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, cc-bugs_chromium.org, jam, chrome-speed-team+watch_google.com
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

cc: Removed unused metrics from RenderingStats. - Removed everything except for frame count, paint/record/rasterize time and pixel count. - Cleaned up variable naming. - Removed RasterStats struct. Replaced by direct usage of RenderingStatsInstrumentation. R=nduca@chromium.org BUG=234308, 280638 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=227666

Patch Set 1 #

Total comments: 2

Patch Set 2 : Removed tree_bin from ManagedTileState. #

Patch Set 3 : Added bin to Value. #

Patch Set 4 : Rebase. #

Patch Set 5 : Fixed raster_worker_pool_perftest.cc #

Unified diffs Side-by-side diffs Delta from patch set Stats (+246 lines, -686 lines) Patch
M cc/debug/rendering_stats.h View 2 chunks +3 lines, -22 lines 0 comments Download
M cc/debug/rendering_stats.cc View 3 chunks +41 lines, -153 lines 0 comments Download
M cc/debug/rendering_stats_instrumentation.h View 1 chunk +3 lines, -25 lines 0 comments Download
M cc/debug/rendering_stats_instrumentation.cc View 2 chunks +7 lines, -115 lines 0 comments Download
M cc/resources/bitmap_skpicture_content_layer_updater.cc View 1 chunk +1 line, -3 lines 0 comments Download
M cc/resources/managed_tile_state.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M cc/resources/managed_tile_state.cc View 1 2 3 chunks +1 line, -7 lines 0 comments Download
M cc/resources/picture.h View 2 chunks +1 line, -3 lines 0 comments Download
M cc/resources/picture.cc View 4 chunks +1 line, -8 lines 0 comments Download
M cc/resources/picture_pile.cc View 2 chunks +3 lines, -8 lines 0 comments Download
M cc/resources/picture_pile_impl.h View 5 chunks +4 lines, -13 lines 0 comments Download
M cc/resources/picture_pile_impl.cc View 7 chunks +22 lines, -25 lines 0 comments Download
M cc/resources/picture_pile_impl_unittest.cc View 4 chunks +6 lines, -6 lines 0 comments Download
M cc/resources/picture_unittest.cc View 7 chunks +3 lines, -7 lines 0 comments Download
M cc/resources/raster_worker_pool.h View 1 chunk +0 lines, -1 line 0 comments Download
M cc/resources/raster_worker_pool.cc View 9 chunks +9 lines, -26 lines 0 comments Download
M cc/resources/raster_worker_pool_perftest.cc View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M cc/resources/skpicture_content_layer_updater.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/resources/tile_manager.cc View 1 5 chunks +8 lines, -8 lines 0 comments Download
M cc/test/fake_picture_pile_impl.cc View 2 chunks +1 line, -4 lines 0 comments Download
M cc/trees/layer_tree_host.cc View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M cc/trees/layer_tree_host_impl.cc View 1 2 3 6 chunks +4 lines, -13 lines 0 comments Download
M cc/trees/single_thread_proxy.cc View 2 chunks +2 lines, -6 lines 0 comments Download
M cc/trees/thread_proxy.cc View 2 chunks +2 lines, -6 lines 0 comments Download
M content/renderer/render_widget.cc View 1 chunk +1 line, -2 lines 0 comments Download
M tools/perf/measurements/smoothness.py View 4 chunks +13 lines, -18 lines 0 comments Download
D tools/perf/metrics/gpu_rendering_stats.py View 1 chunk +0 lines, -168 lines 0 comments Download
A tools/perf/metrics/rendering_stats.py View 1 chunk +95 lines, -0 lines 0 comments Download
M tools/perf/metrics/smoothness.py View 1 2 3 2 chunks +5 lines, -6 lines 0 comments Download
M tools/perf/metrics/smoothness_unittest.py View 1 2 3 6 chunks +9 lines, -29 lines 0 comments Download

Messages

Total messages: 16 (0 generated)
ernstm
7 years, 2 months ago (2013-10-04 18:31:04 UTC) #1
ernstm
+enne +reveman
7 years, 2 months ago (2013-10-04 20:30:37 UTC) #2
reveman
+vmpstr https://codereview.chromium.org/26031002/diff/1/cc/resources/tile_manager.cc File cc/resources/tile_manager.cc (left): https://codereview.chromium.org/26031002/diff/1/cc/resources/tile_manager.cc#oldcode838 cc/resources/tile_manager.cc:838: mts.tree_bin[PENDING_TREE] == NOW_BIN, I think you can also ...
7 years, 2 months ago (2013-10-07 14:12:57 UTC) #3
enne (OOO)
lgtm
7 years, 2 months ago (2013-10-07 17:03:26 UTC) #4
ernstm
https://codereview.chromium.org/26031002/diff/1/cc/resources/tile_manager.cc File cc/resources/tile_manager.cc (left): https://codereview.chromium.org/26031002/diff/1/cc/resources/tile_manager.cc#oldcode838 cc/resources/tile_manager.cc:838: mts.tree_bin[PENDING_TREE] == NOW_BIN, On 2013/10/07 14:12:57, David Reveman wrote: ...
7 years, 2 months ago (2013-10-07 18:19:06 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ernstm@chromium.org/26031002/10001
7 years, 2 months ago (2013-10-07 19:12:48 UTC) #6
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=29134
7 years, 2 months ago (2013-10-07 19:31:30 UTC) #7
ernstm
+dtu +jamesr: Can we get OWNER's reviews for tools/perf/* and content/renderer/* from you?
7 years, 2 months ago (2013-10-07 19:43:27 UTC) #8
jamesr
lgtm
7 years, 2 months ago (2013-10-07 21:19:06 UTC) #9
dtu
tools/perf lgtm
7 years, 2 months ago (2013-10-08 20:44:12 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ernstm@chromium.org/26031002/24001
7 years, 2 months ago (2013-10-08 20:59:59 UTC) #11
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 2 months ago (2013-10-08 21:22:56 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ernstm@chromium.org/26031002/27001
7 years, 2 months ago (2013-10-08 22:31:22 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ernstm@chromium.org/26031002/27001
7 years, 2 months ago (2013-10-09 00:07:26 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ernstm@chromium.org/26031002/27001
7 years, 2 months ago (2013-10-09 02:17:49 UTC) #15
commit-bot: I haz the power
7 years, 2 months ago (2013-10-09 04:04:17 UTC) #16
Message was sent while issue was closed. 
Change committed as 227666

Powered by Google App Engine
This is Rietveld 408576698