Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(838)

Unified Diff: cc/resources/picture_pile.cc

Issue 26031002: cc: Remove unused metrics from RenderingStats. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed raster_worker_pool_perftest.cc Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/resources/picture.cc ('k') | cc/resources/picture_pile_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/resources/picture_pile.cc
diff --git a/cc/resources/picture_pile.cc b/cc/resources/picture_pile.cc
index 2eac495dcbfd8de8b2722c3cbc9dca8077d25925..d2d82f5a025e3671a72ece20489bc12b5a597416 100644
--- a/cc/resources/picture_pile.cc
+++ b/cc/resources/picture_pile.cc
@@ -116,8 +116,6 @@ bool PicturePile::Update(
modified_pile = true;
TRACE_EVENT0(benchmark_instrumentation::kCategory,
benchmark_instrumentation::kRecordLoop);
- base::TimeDelta total_duration =
- base::TimeDelta::FromInternalValue(0);
base::TimeDelta best_duration = base::TimeDelta::FromInternalValue(
std::numeric_limits<int64>::max());
for (int i = 0; i < repeat_count; i++) {
@@ -125,15 +123,12 @@ bool PicturePile::Update(
(*pic)->Record(painter, tile_grid_info_);
base::TimeDelta duration =
stats_instrumentation->EndRecording(start_time);
- total_duration += duration;
best_duration = std::min(duration, best_duration);
}
- int painted_pixels =
+ int recorded_pixel_count =
(*pic)->LayerRect().width() * (*pic)->LayerRect().height();
- stats_instrumentation->AddRecord(total_duration,
- best_duration,
- painted_pixels);
- (*pic)->GatherPixelRefs(tile_grid_info_, stats_instrumentation);
+ stats_instrumentation->AddRecord(best_duration, recorded_pixel_count);
+ (*pic)->GatherPixelRefs(tile_grid_info_);
(*pic)->CloneForDrawing(num_raster_threads_);
}
}
« no previous file with comments | « cc/resources/picture.cc ('k') | cc/resources/picture_pile_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698