Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(302)

Unified Diff: tools/perf/metrics/smoothness.py

Issue 26031002: cc: Remove unused metrics from RenderingStats. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed raster_worker_pool_perftest.cc Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/perf/metrics/rendering_stats.py ('k') | tools/perf/metrics/smoothness_unittest.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/metrics/smoothness.py
diff --git a/tools/perf/metrics/smoothness.py b/tools/perf/metrics/smoothness.py
index 18ad4143306edbf1ddffbe8865cfa83b60c84086..e35af911ea57bf31890ad78b609fd097f478ec1b 100644
--- a/tools/perf/metrics/smoothness.py
+++ b/tools/perf/metrics/smoothness.py
@@ -95,20 +95,20 @@ def CalcResults(benchmark_stats, results):
s = benchmark_stats
frame_times = []
- for i in xrange(1, len(s.screen_frame_timestamps)):
+ for i in xrange(1, len(s.frame_timestamps)):
frame_times.append(
- round(s.screen_frame_timestamps[i] - s.screen_frame_timestamps[i-1], 2))
+ round(s.frame_timestamps[i] - s.frame_timestamps[i-1], 2))
# List of raw frame times.
results.Add('frame_times', 'ms', frame_times)
+ # Arithmetic mean of frame times.
mean_frame_time_ms = 1000 * statistics.ArithmeticMean(
- s.total_time, s.screen_frame_count)
- # Arithmetic mean of frame times. Not the generalized mean.
+ s.total_time, len(s.frame_timestamps))
results.Add('mean_frame_time', 'ms', round(mean_frame_time_ms, 3))
# Absolute discrepancy of frame time stamps.
- jank = statistics.FrameDiscrepancy(s.screen_frame_timestamps)
+ jank = statistics.FrameDiscrepancy(s.frame_timestamps)
results.Add('jank', '', round(jank, 4))
# Are we hitting 60 fps for 95 percent of all frames? (Boolean value)
@@ -133,4 +133,3 @@ def FindTimelineMarker(timeline, name):
if len(events) != 1:
raise MissingTimelineMarker(name)
return events[0]
-
« no previous file with comments | « tools/perf/metrics/rendering_stats.py ('k') | tools/perf/metrics/smoothness_unittest.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698