Created test for title replacement via window.history.replaceState().

Created test for title replacement via window.history.replaceState().

This is currently disabled, as NavigationItem title updating requires
a web delegate, which is not present in this test fixture.

BUG=673022
Review-Url: https://codereview.chromium.org/2606003002
Cr-Commit-Position: refs/heads/master@{#445830}
Committed: https://chromium.googlesource.com/chromium/src/+/83f3676db831f10d529b255fa73a651b26abc2a5

[kkhorimoto, 2016-12-29 04:02:34]

kkhorimoto@chromium.org changed reviewers:
+ eugenebut@chromium.org

[Eugene But (OOO till 7-30), 2016-12-29 17:09:48]

lgtm

https://codereview.chromium.org/2606003002/diff/1/ios/web/navigation/history_...
File ios/web/navigation/history_state_operations_inttest.mm (right):

https://codereview.chromium.org/2606003002/diff/1/ios/web/navigation/history_...
ios/web/navigation/history_state_operations_inttest.mm:282: std::string
empty_state("");
std::string empty_state;

https://codereview.chromium.org/2606003002/diff/1/ios/web/navigation/history_...
ios/web/navigation/history_state_operations_inttest.mm:284: GURL empty_url("");
GURL empty_url;

https://codereview.chromium.org/2606003002/diff/1/ios/web/navigation/history_...
ios/web/navigation/history_state_operations_inttest.mm:290: title_updated =
current_item()->GetTitle() == ASCIIToUTF16(new_title);
nit: |return current_item()->GetTitle() == ASCIIToUTF16(new_title);|

https://codereview.chromium.org/2606003002/diff/1/ios/web/navigation/history_...
ios/web/navigation/history_state_operations_inttest.mm:293:
EXPECT_TRUE(title_updated);
You don't need this. WaitUntilCondition will not successfully return until
|title_updated| is true.

[kkhorimoto, 2017-01-24 04:40:59]

https://codereview.chromium.org/2606003002/diff/1/ios/web/navigation/history_...
File ios/web/navigation/history_state_operations_inttest.mm (right):

https://codereview.chromium.org/2606003002/diff/1/ios/web/navigation/history_...
ios/web/navigation/history_state_operations_inttest.mm:282: std::string
empty_state("");
On 2016/12/29 17:09:48, Eugene But wrote:
> std::string empty_state;

Done.

https://codereview.chromium.org/2606003002/diff/1/ios/web/navigation/history_...
ios/web/navigation/history_state_operations_inttest.mm:284: GURL empty_url("");
On 2016/12/29 17:09:48, Eugene But wrote:
> GURL empty_url;

Done.

https://codereview.chromium.org/2606003002/diff/1/ios/web/navigation/history_...
ios/web/navigation/history_state_operations_inttest.mm:290: title_updated =
current_item()->GetTitle() == ASCIIToUTF16(new_title);
On 2016/12/29 17:09:48, Eugene But wrote:
> nit: |return current_item()->GetTitle() == ASCIIToUTF16(new_title);|

Done.

https://codereview.chromium.org/2606003002/diff/1/ios/web/navigation/history_...
ios/web/navigation/history_state_operations_inttest.mm:293:
EXPECT_TRUE(title_updated);
On 2016/12/29 17:09:48, Eugene But wrote:
> You don't need this. WaitUntilCondition will not successfully return until
> |title_updated| is true.

Done.

[kkhorimoto, 2017-01-24 21:47:58]

The CQ bit was checked by kkhorimoto@chromium.org

[kkhorimoto, 2017-01-24 21:47:59]

The patchset sent to the CQ was uploaded after l-g-t-m from
eugenebut@chromium.org
Link to the patchset: https://codereview.chromium.org/2606003002/#ps20001
(title: "rebase & eugene's comments")

[commit-bot: I haz the power, 2017-01-24 21:48:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-24 22:01:31]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1485294478849920,
"parent_rev": "e003d59373ed5f176a8b521c15a7fc0a6ff6876f", "commit_rev":
"83f3676db831f10d529b255fa73a651b26abc2a5"}

[commit-bot: I haz the power, 2017-01-24 22:03:48]

Description was changed from

==========
Created test for title replacement via window.history.replaceState().

This is currently disabled, as NavigationItem title updating requires
a web delegate, which is not present in this test fixture.

BUG=673022
==========

to

==========
Created test for title replacement via window.history.replaceState().

This is currently disabled, as NavigationItem title updating requires
a web delegate, which is not present in this test fixture.

BUG=673022

Review-Url: https://codereview.chromium.org/2606003002
Cr-Commit-Position: refs/heads/master@{#445830}
Committed:
https://chromium.googlesource.com/chromium/src/+/83f3676db831f10d529b255fa73a...
==========

[commit-bot: I haz the power, 2017-01-24 22:03:49]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/83f3676db831f10d529b255fa73a...