Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 2601513003: Fix the title alignment for the password bubble on Mac. (Closed)

Created:
4 years ago by vasilii
Modified:
4 years ago
Reviewers:
vabr (Chromium)
CC:
chromium-reviews, mac-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix the title alignment for the password bubble on Mac. It should be right aligned for RTL text. Only two bubbles have a bug - manage passwords and generation confirmation. BUG=666340 Committed: https://crrev.com/05f484a7a00ceeab63c137d3ebf686c57e9ad130 Cr-Commit-Position: refs/heads/master@{#440452}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -4 lines) Patch
M chrome/browser/ui/cocoa/passwords/base_passwords_content_view_controller.mm View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/passwords/confirmation_password_saved_view_controller.mm View 2 chunks +5 lines, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/passwords/manage_passwords_view_controller.mm View 1 chunk +2 lines, -4 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
vasilii
Hi Vaclav, please review
4 years ago (2016-12-22 16:34:29 UTC) #4
vabr (Chromium)
LGTM, both the fix and its description. Cheers, Vaclav
4 years ago (2016-12-22 16:40:40 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2601513003/1
4 years ago (2016-12-22 18:19:20 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-22 18:23:52 UTC) #12
commit-bot: I haz the power
4 years ago (2016-12-22 18:26:31 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/05f484a7a00ceeab63c137d3ebf686c57e9ad130
Cr-Commit-Position: refs/heads/master@{#440452}

Powered by Google App Engine
This is Rietveld 408576698