chrome/browser/ui/cocoa/passwords/confirmation_password_saved_view_controller.mm - Issue 2601513003: Fix the title alignment for the password bubble on Mac.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/passwords/confirmation_password_saved_view_controller.mm

Issue 2601513003: Fix the title alignment for the password bubble on Mac. (Closed)

Patch Set: Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/passwords/base_passwords_content_view_controller.mm ('k') | chrome/browser/ui/cocoa/passwords/manage_passwords_view_controller.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/passwords/confirmation_password_saved_view_controller.mm

diff --git a/chrome/browser/ui/cocoa/passwords/confirmation_password_saved_view_controller.mm b/chrome/browser/ui/cocoa/passwords/confirmation_password_saved_view_controller.mm

index 9727315c0d9db6d6c05f1510d62fae96ccd89da3..fe0224751084cc21784a6f9843bbb9f2d2a5f1d6 100644

--- a/chrome/browser/ui/cocoa/passwords/confirmation_password_saved_view_controller.mm

+++ b/chrome/browser/ui/cocoa/passwords/confirmation_password_saved_view_controller.mm

@@ -13,6 +13,7 @@

#include "chrome/grit/generated_resources.h"

#include "components/strings/grit/components_strings.h"

#include "skia/ext/skia_utils_mac.h"

+#import "third_party/google_toolbox_for_mac/src/AppKit/GTMUILocalizerAndLayoutTweaker.h"

#import "ui/base/cocoa/controls/hyperlink_text_view.h"

#include "ui/base/l10n/l10n_util.h"

#include "ui/base/resource/resource_bundle.h"

@@ -64,6 +65,10 @@

NSTextField* titleLabel =

[self addTitleLabel:base::SysUTF16ToNSString(self.model->title())

toView:view];

+ // Title should occupy the whole width to that it's aligned properly for RTL.

+ [titleLabel setFrameSize:NSMakeSize(kDesiredBubbleWidth - 2 * kFramePadding,

+ 0)];

+ [GTMUILocalizerAndLayoutTweaker sizeToFitFixedWidthTextField:titleLabel];

// Text.

confirmationText_.reset([[HyperlinkTextView alloc] initWithFrame:NSZeroRect]);