Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(943)

Issue 2601143002: [Extensions Bindings] Add a GetStringPropertyFromObject test method (Closed)

Created:
3 years, 11 months ago by Devlin
Modified:
3 years, 11 months ago
Reviewers:
lazyboy
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, jbroman
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Extensions Bindings] Add a GetStringPropertyFromObject test method Common test practice: compare a stringified property on an object to an expected value (we use strings for easy readability if something is unexpected). Add a method to streamline the process a bit. BUG=653596 Committed: https://crrev.com/371ae771a1d9bf25eeb726275c558468083cf9a8 Cr-Commit-Position: refs/heads/master@{#440904}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -71 lines) Patch
M extensions/renderer/api_binding_test_util.h View 1 chunk +6 lines, -0 lines 0 comments Download
M extensions/renderer/api_binding_test_util.cc View 1 chunk +17 lines, -0 lines 0 comments Download
M extensions/renderer/api_bindings_system_unittest.cc View 5 chunks +15 lines, -23 lines 0 comments Download
M extensions/renderer/api_event_handler_unittest.cc View 3 chunks +14 lines, -20 lines 0 comments Download
M extensions/renderer/api_request_handler_unittest.cc View 3 chunks +8 lines, -13 lines 0 comments Download
M extensions/renderer/native_extension_bindings_system_unittest.cc View 1 chunk +7 lines, -15 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
Devlin
lazyboy@, mind taking a look? Just adding another test function. jbroman@ FYI.
3 years, 11 months ago (2016-12-28 22:09:35 UTC) #4
lazyboy
lgtm
3 years, 11 months ago (2016-12-28 22:56:40 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2601143002/1
3 years, 11 months ago (2016-12-28 23:35:15 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
3 years, 11 months ago (2016-12-28 23:39:16 UTC) #12
commit-bot: I haz the power
3 years, 11 months ago (2017-01-02 15:50:42 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/371ae771a1d9bf25eeb726275c558468083cf9a8
Cr-Commit-Position: refs/heads/master@{#440904}

Powered by Google App Engine
This is Rietveld 408576698