[Extensions Bindings] Add a GetStringPropertyFromObject test method

extensions/renderer/api_request_handler_unittest.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/bind.h"
 #include "base/guid.h"
 #include "base/json/json_reader.h"
 #include "base/json/json_writer.h"
 #include "base/strings/string_util.h"
 #include "base/values.h"
@@ skipping 60 matching lines @@
   EXPECT_THAT(request_handler.GetPendingRequestIdsForTesting(),
               testing::UnorderedElementsAre(request_id));
 
   const char kArguments[] = "['foo',1,{'prop1':'bar'}]";
   std::unique_ptr<base::ListValue> response_arguments =
       ListValueFromString(kArguments);
   ASSERT_TRUE(response_arguments);
   request_handler.CompleteRequest(request_id, *response_arguments);
 
   EXPECT_TRUE(did_run_js());
-  std::unique_ptr<base::Value> result_value =
-      GetBaseValuePropertyFromObject(context->Global(), context, "result");
-  ASSERT_TRUE(result_value);
-  EXPECT_EQ(ReplaceSingleQuotes(kArguments), ValueToString(*result_value));
+  EXPECT_EQ(ReplaceSingleQuotes(kArguments),
+            GetStringPropertyFromObject(context->Global(), context, "result"));
 
   EXPECT_TRUE(request_handler.GetPendingRequestIdsForTesting().empty());
 }
 
 // Tests that trying to run non-existent or invalided requests is a no-op.
 TEST_F(APIRequestHandlerTest, InvalidRequestsTest) {
   v8::Isolate* isolate = instance_->isolate();
   v8::HandleScope handle_scope(instance_->isolate());
   v8::Local<v8::Context> context =
       v8::Local<v8::Context>::New(instance_->isolate(), context_);
@@ skipping 52 matching lines @@
 
   std::unique_ptr<base::ListValue> response_a =
       ListValueFromString("['response_a:']");
   ASSERT_TRUE(response_a);
 
   request_handler.CompleteRequest(request_a, *response_a);
   EXPECT_TRUE(did_run_js());
   EXPECT_THAT(request_handler.GetPendingRequestIdsForTesting(),
               testing::UnorderedElementsAre(request_b));
 
-  std::unique_ptr<base::Value> result_a =
-      GetBaseValuePropertyFromObject(context_a->Global(), context_a, "result");
-  ASSERT_TRUE(result_a);
-  EXPECT_EQ(ReplaceSingleQuotes("'response_a:alpha'"),
-            ValueToString(*result_a));
+  EXPECT_EQ(
+      ReplaceSingleQuotes("'response_a:alpha'"),
+      GetStringPropertyFromObject(context_a->Global(), context_a, "result"));
 
   std::unique_ptr<base::ListValue> response_b =
       ListValueFromString("['response_b:']");
   ASSERT_TRUE(response_b);
 
   request_handler.CompleteRequest(request_b, *response_b);
   EXPECT_TRUE(request_handler.GetPendingRequestIdsForTesting().empty());
 
-  std::unique_ptr<base::Value> result_b =
-      GetBaseValuePropertyFromObject(context_b->Global(), context_b, "result");
-  ASSERT_TRUE(result_b);
-  EXPECT_EQ(ReplaceSingleQuotes("'response_b:beta'"), ValueToString(*result_b));
+  EXPECT_EQ(
+      ReplaceSingleQuotes("'response_b:beta'"),
+      GetStringPropertyFromObject(context_b->Global(), context_b, "result"));
 }
 
 }  // namespace extensions