Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(534)

Unified Diff: extensions/renderer/api_request_handler_unittest.cc

Issue 2601143002: [Extensions Bindings] Add a GetStringPropertyFromObject test method (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/renderer/api_request_handler_unittest.cc
diff --git a/extensions/renderer/api_request_handler_unittest.cc b/extensions/renderer/api_request_handler_unittest.cc
index 5333f7e66e11dd7fc4d36e49698211fefcf83a64..1aa6fc9b475f4033db952919c454beebfbd352d9 100644
--- a/extensions/renderer/api_request_handler_unittest.cc
+++ b/extensions/renderer/api_request_handler_unittest.cc
@@ -78,10 +78,8 @@ TEST_F(APIRequestHandlerTest, AddRequestAndCompleteRequestTest) {
request_handler.CompleteRequest(request_id, *response_arguments);
EXPECT_TRUE(did_run_js());
- std::unique_ptr<base::Value> result_value =
- GetBaseValuePropertyFromObject(context->Global(), context, "result");
- ASSERT_TRUE(result_value);
- EXPECT_EQ(ReplaceSingleQuotes(kArguments), ValueToString(*result_value));
+ EXPECT_EQ(ReplaceSingleQuotes(kArguments),
+ GetStringPropertyFromObject(context->Global(), context, "result"));
EXPECT_TRUE(request_handler.GetPendingRequestIdsForTesting().empty());
}
@@ -154,11 +152,9 @@ TEST_F(APIRequestHandlerTest, MultipleRequestsAndContexts) {
EXPECT_THAT(request_handler.GetPendingRequestIdsForTesting(),
testing::UnorderedElementsAre(request_b));
- std::unique_ptr<base::Value> result_a =
- GetBaseValuePropertyFromObject(context_a->Global(), context_a, "result");
- ASSERT_TRUE(result_a);
- EXPECT_EQ(ReplaceSingleQuotes("'response_a:alpha'"),
- ValueToString(*result_a));
+ EXPECT_EQ(
+ ReplaceSingleQuotes("'response_a:alpha'"),
+ GetStringPropertyFromObject(context_a->Global(), context_a, "result"));
std::unique_ptr<base::ListValue> response_b =
ListValueFromString("['response_b:']");
@@ -167,10 +163,9 @@ TEST_F(APIRequestHandlerTest, MultipleRequestsAndContexts) {
request_handler.CompleteRequest(request_b, *response_b);
EXPECT_TRUE(request_handler.GetPendingRequestIdsForTesting().empty());
- std::unique_ptr<base::Value> result_b =
- GetBaseValuePropertyFromObject(context_b->Global(), context_b, "result");
- ASSERT_TRUE(result_b);
- EXPECT_EQ(ReplaceSingleQuotes("'response_b:beta'"), ValueToString(*result_b));
+ EXPECT_EQ(
+ ReplaceSingleQuotes("'response_b:beta'"),
+ GetStringPropertyFromObject(context_b->Global(), context_b, "result"));
}
} // namespace extensions
« no previous file with comments | « extensions/renderer/api_event_handler_unittest.cc ('k') | extensions/renderer/native_extension_bindings_system_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698