[turbofan] Lower StringCharCodeAt to a dedicated builtin.

[turbofan] Lower StringCharCodeAt to a dedicated builtin.

Introduce a dedicated StringCharCodeAt builtin, that performs the core
logic of String.prototype.charCodeAt and lower the StringCharCodeAt
simplified operator to a call to this builtin rather than inlining the
full functionality into each and every TurboFan graph using it. This can
significantly reduce compile time in some cases (i.e. can easily shave
off over 50% of compile time overhead for small functions that call
String.prototype.charCodeAt).

Currently it returns the char code as TaggedSigned value, but
middle-term we should make it possible to return untagged values
from builtins.

R=yangguo@chromium.org

Review-Url: https://codereview.chromium.org/2600443002
Cr-Commit-Position: refs/heads/master@{#41912}
Committed: https://chromium.googlesource.com/v8/v8/+/86e2a19991068c99f4340df87c9b4861e76023af

[Benedikt Meurer, 2016-12-22 06:37:48]

The CQ bit was checked by bmeurer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-22 06:37:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Yang, 2016-12-22 06:41:32]

On 2016/12/22 06:37:47, Benedikt Meurer wrote:

lgtm

[Benedikt Meurer, 2016-12-22 06:58:06]

The CQ bit was unchecked by bmeurer@chromium.org

[Benedikt Meurer, 2016-12-22 06:58:10]

The CQ bit was checked by bmeurer@chromium.org

[commit-bot: I haz the power, 2016-12-22 06:58:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-22 07:11:23]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1482389890205590, "parent_rev":
"381082168d37d4f2794360ae31dc078f2a350113", "commit_rev":
"86e2a19991068c99f4340df87c9b4861e76023af"}

[commit-bot: I haz the power, 2016-12-22 07:11:27]

Description was changed from

==========
[turbofan] Lower StringCharCodeAt to a dedicated builtin.

Introduce a dedicated StringCharCodeAt builtin, that performs the core
logic of String.prototype.charCodeAt and lower the StringCharCodeAt
simplified operator to a call to this builtin rather than inlining the
full functionality into each and every TurboFan graph using it. This can
significantly reduce compile time in some cases (i.e. can easily shave
off over 50% of compile time overhead for small functions that call
String.prototype.charCodeAt).

Currently it returns the char code as TaggedSigned value, but
middle-term we should make it possible to return untagged values
from builtins.

R=yangguo@chromium.org
==========

to

==========
[turbofan] Lower StringCharCodeAt to a dedicated builtin.

Introduce a dedicated StringCharCodeAt builtin, that performs the core
logic of String.prototype.charCodeAt and lower the StringCharCodeAt
simplified operator to a call to this builtin rather than inlining the
full functionality into each and every TurboFan graph using it. This can
significantly reduce compile time in some cases (i.e. can easily shave
off over 50% of compile time overhead for small functions that call
String.prototype.charCodeAt).

Currently it returns the char code as TaggedSigned value, but
middle-term we should make it possible to return untagged values
from builtins.

R=yangguo@chromium.org

Review-Url: https://codereview.chromium.org/2600443002
Cr-Commit-Position: refs/heads/master@{#41912}
Committed:
https://chromium.googlesource.com/v8/v8/+/86e2a19991068c99f4340df87c9b4861e76...
==========

[commit-bot: I haz the power, 2016-12-22 07:11:28]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/86e2a19991068c99f4340df87c9b4861e76...