Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Issue 2599683002: [turbofan] Introduce a dedicated StringCharAt operator. (Closed)

Created:
4 years ago by Benedikt Meurer
Modified:
4 years ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Introduce a dedicated StringCharAt operator. Previously String element access and String.prototype.charAt were lowered to a subgraph StringFromCharCode(StringCharCodeAt(s, k)), however that can be fairly expensive both runtime and compile time wise. The dedicated StringCharAt operator is implemented via a call to a builtin that does exactly this. R=yangguo@chromium.org Review-Url: https://codereview.chromium.org/2599683002 Cr-Commit-Position: refs/heads/master@{#41909} Committed: https://chromium.googlesource.com/v8/v8/+/05f5ebce2f34753d0fb32fd2f3b6e652c8682e09

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+90 lines, -23 lines) Patch
M src/builtins/builtins.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/builtins/builtins-string.cc View 1 chunk +17 lines, -0 lines 0 comments Download
M src/code-factory.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/code-factory.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/code-stub-assembler.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/code-stub-assembler.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M src/compiler/effect-control-linearizer.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/effect-control-linearizer.cc View 2 chunks +19 lines, -0 lines 0 comments Download
M src/compiler/js-builtin-reducer.cc View 1 chunk +3 lines, -9 lines 0 comments Download
M src/compiler/js-native-context-specialization.cc View 2 chunks +5 lines, -11 lines 0 comments Download
M src/compiler/opcodes.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/simplified-lowering.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M src/compiler/simplified-operator.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/simplified-operator.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/typer.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M src/compiler/verifier.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M src/interface-descriptors.h View 2 chunks +7 lines, -0 lines 0 comments Download
M src/interface-descriptors.cc View 1 chunk +14 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 10 (6 generated)
Benedikt Meurer
4 years ago (2016-12-22 06:04:39 UTC) #1
Yang
On 2016/12/22 06:04:39, Benedikt Meurer wrote: lgtm.
4 years ago (2016-12-22 06:06:49 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2599683002/1
4 years ago (2016-12-22 06:07:16 UTC) #7
commit-bot: I haz the power
4 years ago (2016-12-22 06:49:13 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/05f5ebce2f34753d0fb32fd2f3b6e652c86...

Powered by Google App Engine
This is Rietveld 408576698