Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(811)

Issue 2597913002: [turbofan] Relax index type constraints for StringCharAt/StringCharCodeAt. (Closed)

Created:
3 years, 12 months ago by Benedikt Meurer
Modified:
3 years, 12 months ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Relax index type constraints for StringCharAt/StringCharCodeAt. Also support inlining the builtins String.prototype.charCodeAt and String.prototype.charAt if the index type is not statically known to be in the Unsigned32 range, but in anything in Integral32 plus minus zero and NaN. R=yangguo@chromium.org Review-Url: https://codereview.chromium.org/2597913002 Cr-Commit-Position: refs/heads/master@{#41913} Committed: https://chromium.googlesource.com/v8/v8/+/89259657b9d0953ce038a6411f414fd00a8c7a89

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -2 lines) Patch
M src/compiler/js-builtin-reducer.cc View 2 chunks +20 lines, -2 lines 0 comments Download
M src/compiler/types.h View 1 chunk +1 line, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 11 (7 generated)
Benedikt Meurer
3 years, 12 months ago (2016-12-22 06:57:42 UTC) #1
Yang
On 2016/12/22 06:57:42, Benedikt Meurer wrote: lgtm.
3 years, 12 months ago (2016-12-22 07:34:12 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2597913002/1
3 years, 12 months ago (2016-12-22 07:34:24 UTC) #8
commit-bot: I haz the power
3 years, 12 months ago (2016-12-22 07:36:03 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/89259657b9d0953ce038a6411f414fd00a8...

Powered by Google App Engine
This is Rietveld 408576698