[ARM] Add vrecpe, vrecps, vrsqrte, vrsqrts instructions to assembler.

[ARM] Add vrecpe, vrecps, vrsqrte, vrsqrts instructions to assembler.
- Disassembler, simulator support too.
LOG=N
BUG=v8:4124
Review-Url: https://codereview.chromium.org/2600153002
Cr-Commit-Position: refs/heads/master@{#42176}
Committed: https://chromium.googlesource.com/v8/v8/+/8dfea24e3d8c7137ffae3bcaa24ad282b82485e5

[bbudge, 2016-12-27 00:28:46]

The CQ bit was checked by bbudge@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-27 00:28:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-27 00:55:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-27 00:55:19]

Dry run: This issue passed the CQ dry run.

[bbudge, 2016-12-27 01:45:12]

bbudge@chromium.org changed reviewers:
+ rodolph.perfetta@arm.com

[bbudge, 2016-12-27 10:50:20]

Description was changed from

==========
[ARM] Add vrecpe, vrecps instructions to assembler.
- Disassembler, simulator support too.
LOG=N
BUG=v8:4124
==========

to

==========
[ARM] Add vrecpe, vrecps, vrsqrte, vrsqrts instructions to assembler.
- Disassembler, simulator support too.
LOG=N
BUG=v8:4124
==========

[bbudge, 2016-12-27 11:02:14]

The CQ bit was checked by bbudge@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-27 11:02:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-27 11:28:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-27 11:28:52]

Dry run: This issue passed the CQ dry run.

[bbudge, 2017-01-06 11:46:27]

bbudge@chromium.org changed reviewers:
+ martyn.capewell@arm.com

[bbudge, 2017-01-06 11:46:27]

+Martyn

[martyn.capewell, 2017-01-06 17:48:51]

https://codereview.chromium.org/2600153002/diff/60001/src/arm/assembler-arm.cc
File src/arm/assembler-arm.cc (right):

https://codereview.chromium.org/2600153002/diff/60001/src/arm/assembler-arm.c...
src/arm/assembler-arm.cc:4246: // Qd = vadd(Qn, Qm) SIMD reciprocal estimate.
It would be worth commenting that these estimate (e) instructions only support
F32 arguments at the moment, as the F field is fixed to 1.

[bbudge, 2017-01-10 10:18:54]

The CQ bit was checked by bbudge@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-10 10:19:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-10 10:45:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-10 10:45:50]

Dry run: This issue passed the CQ dry run.

[bbudge, 2017-01-10 11:00:00]

Rebased, then added the comment as you suggested.

https://codereview.chromium.org/2600153002/diff/60001/src/arm/assembler-arm.cc
File src/arm/assembler-arm.cc (right):

https://codereview.chromium.org/2600153002/diff/60001/src/arm/assembler-arm.c...
src/arm/assembler-arm.cc:4246: // Qd = vadd(Qn, Qm) SIMD reciprocal estimate.
On 2017/01/06 17:48:51, martyn.capewell wrote:
> It would be worth commenting that these estimate (e) instructions only support
> F32 arguments at the moment, as the F field is fixed to 1.

Done.

[martyn.capewell, 2017-01-10 11:48:52]

lgtm

[bbudge, 2017-01-10 12:35:20]

The CQ bit was checked by bbudge@chromium.org

[commit-bot: I haz the power, 2017-01-10 12:35:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-10 12:37:00]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1484051720172310,
"parent_rev": "fc86d4329b253bf21c1dd85469f1ef4b6e5ba01a", "commit_rev":
"8dfea24e3d8c7137ffae3bcaa24ad282b82485e5"}

[commit-bot: I haz the power, 2017-01-10 12:37:03]

Description was changed from

==========
[ARM] Add vrecpe, vrecps, vrsqrte, vrsqrts instructions to assembler.
- Disassembler, simulator support too.
LOG=N
BUG=v8:4124
==========

to

==========
[ARM] Add vrecpe, vrecps, vrsqrte, vrsqrts instructions to assembler.
- Disassembler, simulator support too.
LOG=N
BUG=v8:4124

Review-Url: https://codereview.chromium.org/2600153002
Cr-Commit-Position: refs/heads/master@{#42176}
Committed:
https://chromium.googlesource.com/v8/v8/+/8dfea24e3d8c7137ffae3bcaa24ad282b82...
==========

[commit-bot: I haz the power, 2017-01-10 12:37:07]

Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/v8/v8/+/8dfea24e3d8c7137ffae3bcaa24ad282b82...

[Michael Achenbach, 2017-01-12 11:06:03]

This seems to break on chromebooks with arm:
https://build.chromium.org/p/client.v8.ports/builders/V8%20Arm%20-%20debug/bu...

Could you please take a look? Fails also on the release builder, but in the
build above, bisect nearly narrows it down to this CL.