Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Issue 2599853003: Remove SVGAnimateElement::hasValidAttributeType (Closed)

Created:
3 years, 12 months ago by fs
Modified:
3 years, 11 months ago
Reviewers:
pdr., Stephen Chennney
CC:
fs, darktears, blink-reviews, blink-reviews-animation_chromium.org, chromium-reviews, krit, Eric Willigers, f(malita), gyuyoung2, kouhei+svg_chromium.org, pdr+svgwatchlist_chromium.org, rjwright, rwlbuis, Stephen Chennney, shans
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove SVGAnimateElement::hasValidAttributeType Incorporate said method into its only caller - hasValidTarget - and override that one in SVGAnimateTransformElement instead. Also fold animatedPropertyType() into hasValidTarget and get rid of hasInvalidCSSAttributeType() in favor of "naked" access to the underlying boolean flag. BUG=641437 Committed: https://crrev.com/5795f556552fe3d6bcd19d8854ee97d223c96cbf Cr-Commit-Position: refs/heads/master@{#440716}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -21 lines) Patch
M third_party/WebKit/Source/core/svg/SVGAnimateElement.h View 2 chunks +2 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGAnimateElement.cpp View 1 chunk +6 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGAnimateTransformElement.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/SVGAnimateTransformElement.cpp View 1 chunk +3 lines, -6 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
fs
3 years, 12 months ago (2016-12-23 14:40:10 UTC) #6
Stephen Chennney
lgtm
3 years, 12 months ago (2016-12-23 20:02:14 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2599853003/1
3 years, 12 months ago (2016-12-26 15:51:36 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
3 years, 12 months ago (2016-12-26 17:18:16 UTC) #12
commit-bot: I haz the power
3 years, 11 months ago (2017-01-02 15:45:05 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5795f556552fe3d6bcd19d8854ee97d223c96cbf
Cr-Commit-Position: refs/heads/master@{#440716}

Powered by Google App Engine
This is Rietveld 408576698