Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(619)

Unified Diff: third_party/WebKit/Source/core/svg/SVGAnimateElement.cpp

Issue 2599853003: Remove SVGAnimateElement::hasValidAttributeType (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/svg/SVGAnimateElement.cpp
diff --git a/third_party/WebKit/Source/core/svg/SVGAnimateElement.cpp b/third_party/WebKit/Source/core/svg/SVGAnimateElement.cpp
index ee425ba764a2deff0e630de1dccfb53d2b05cb4f..71ee51eba1df8af4c95f5de1347772df1c2ed709 100644
--- a/third_party/WebKit/Source/core/svg/SVGAnimateElement.cpp
+++ b/third_party/WebKit/Source/core/svg/SVGAnimateElement.cpp
@@ -164,21 +164,18 @@ AnimatedPropertyType SVGAnimateElement::animatedPropertyType() {
}
bool SVGAnimateElement::hasValidTarget() {
- return SVGAnimationElement::hasValidTarget() && hasValidAttributeName() &&
- hasValidAttributeType();
+ if (!SVGAnimationElement::hasValidTarget())
+ return false;
+ if (!hasValidAttributeName())
+ return false;
+ resolveTargetProperty();
+ return m_type != AnimatedUnknown && !m_hasInvalidCSSAttributeType;
}
bool SVGAnimateElement::hasValidAttributeName() const {
return attributeName() != anyQName();
}
-bool SVGAnimateElement::hasValidAttributeType() {
- if (!targetElement())
- return false;
- return animatedPropertyType() != AnimatedUnknown &&
- !hasInvalidCSSAttributeType();
-}
-
bool SVGAnimateElement::shouldApplyAnimation(
const SVGElement& targetElement,
const QualifiedName& attributeName) {

Powered by Google App Engine
This is Rietveld 408576698