Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Side by Side Diff: third_party/WebKit/Source/core/svg/SVGAnimateElement.h

Issue 2599853003: Remove SVGAnimateElement::hasValidAttributeType (Closed)
Patch Set: Created 3 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/svg/SVGAnimateElement.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2004, 2005 Nikolas Zimmermann <zimmermann@kde.org> 2 * Copyright (C) 2004, 2005 Nikolas Zimmermann <zimmermann@kde.org>
3 * Copyright (C) 2004, 2005 Rob Buis <buis@kde.org> 3 * Copyright (C) 2004, 2005 Rob Buis <buis@kde.org>
4 * Copyright (C) 2008 Apple Inc. All rights reserved. 4 * Copyright (C) 2008 Apple Inc. All rights reserved.
5 * Copyright (C) Research In Motion Limited 2011. All rights reserved. 5 * Copyright (C) Research In Motion Limited 2011. All rights reserved.
6 * 6 *
7 * This library is free software; you can redistribute it and/or 7 * This library is free software; you can redistribute it and/or
8 * modify it under the terms of the GNU Library General Public 8 * modify it under the terms of the GNU Library General Public
9 * License as published by the Free Software Foundation; either 9 * License as published by the Free Software Foundation; either
10 * version 2 of the License, or (at your option) any later version. 10 * version 2 of the License, or (at your option) any later version.
(...skipping 36 matching lines...) Expand 10 before | Expand all | Expand 10 after
47 47
48 bool isSVGAnimationAttributeSettingJavaScriptURL( 48 bool isSVGAnimationAttributeSettingJavaScriptURL(
49 const Attribute&) const override; 49 const Attribute&) const override;
50 50
51 AnimatedPropertyType animatedPropertyType(); 51 AnimatedPropertyType animatedPropertyType();
52 bool animatedPropertyTypeSupportsAddition(); 52 bool animatedPropertyTypeSupportsAddition();
53 53
54 protected: 54 protected:
55 SVGAnimateElement(const QualifiedName&, Document&); 55 SVGAnimateElement(const QualifiedName&, Document&);
56 56
57 bool hasValidTarget() override;
58
57 void resetAnimatedType() final; 59 void resetAnimatedType() final;
58 void clearAnimatedType() final; 60 void clearAnimatedType() final;
59 61
60 bool calculateToAtEndOfDurationValue( 62 bool calculateToAtEndOfDurationValue(
61 const String& toAtEndOfDurationString) final; 63 const String& toAtEndOfDurationString) final;
62 bool calculateFromAndToValues(const String& fromString, 64 bool calculateFromAndToValues(const String& fromString,
63 const String& toString) final; 65 const String& toString) final;
64 bool calculateFromAndByValues(const String& fromString, 66 bool calculateFromAndByValues(const String& fromString,
65 const String& byString) final; 67 const String& byString) final;
66 void calculateAnimatedValue(float percentage, 68 void calculateAnimatedValue(float percentage,
(...skipping 20 matching lines...) Expand all
87 89
88 private: 90 private:
89 void resetAnimatedPropertyType(); 91 void resetAnimatedPropertyType();
90 92
91 bool shouldApplyAnimation(const SVGElement& targetElement, 93 bool shouldApplyAnimation(const SVGElement& targetElement,
92 const QualifiedName& attributeName); 94 const QualifiedName& attributeName);
93 95
94 void setAttributeType(const AtomicString&); 96 void setAttributeType(const AtomicString&);
95 97
96 void checkInvalidCSSAttributeType(); 98 void checkInvalidCSSAttributeType();
97 bool hasInvalidCSSAttributeType() const {
98 return m_hasInvalidCSSAttributeType;
99 }
100 bool hasValidTarget() final;
101 bool hasValidAttributeName() const; 99 bool hasValidAttributeName() const;
102 virtual bool hasValidAttributeType();
103 100
104 virtual void resolveTargetProperty(); 101 virtual void resolveTargetProperty();
105 void clearTargetProperty(); 102 void clearTargetProperty();
106 103
107 virtual SVGPropertyBase* createPropertyForAnimation(const String&) const; 104 virtual SVGPropertyBase* createPropertyForAnimation(const String&) const;
108 SVGPropertyBase* createPropertyForAttributeAnimation(const String&) const; 105 SVGPropertyBase* createPropertyForAttributeAnimation(const String&) const;
109 SVGPropertyBase* createPropertyForCSSAnimation(const String&) const; 106 SVGPropertyBase* createPropertyForCSSAnimation(const String&) const;
110 107
111 SVGPropertyBase* adjustForInheritance(SVGPropertyBase*, 108 SVGPropertyBase* adjustForInheritance(SVGPropertyBase*,
112 AnimatedPropertyValueType) const; 109 AnimatedPropertyValueType) const;
(...skipping 24 matching lines...) Expand all
137 return element.hasTagName(SVGNames::animateTag) || 134 return element.hasTagName(SVGNames::animateTag) ||
138 element.hasTagName(SVGNames::animateTransformTag) || 135 element.hasTagName(SVGNames::animateTransformTag) ||
139 element.hasTagName(SVGNames::setTag); 136 element.hasTagName(SVGNames::setTag);
140 } 137 }
141 138
142 DEFINE_SVGELEMENT_TYPE_CASTS_WITH_FUNCTION(SVGAnimateElement); 139 DEFINE_SVGELEMENT_TYPE_CASTS_WITH_FUNCTION(SVGAnimateElement);
143 140
144 } // namespace blink 141 } // namespace blink
145 142
146 #endif // SVGAnimateElement_h 143 #endif // SVGAnimateElement_h
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/svg/SVGAnimateElement.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698