Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2599243002:
[reland] Enable no-compile tests on linux clang (Closed)
Description[reland] Enable no-compile tests on linux clang
BUG=105388
Committed: https://crrev.com/4f7b28c2ea7d46ff26d550e7c16b1a151c213d68
Cr-Commit-Position: refs/heads/master@{#441338}
Patch Set 1 : Copy from https://codereview.chromium.org/2594943002/ #Patch Set 2 : rebase on sysroot fix #
Depends on Patchset: Messages
Total messages: 27 (17 generated)
Description was changed from ========== Enable no-compile tests on linux clang BUG=105388 ========== to ========== [reland] Enable no-compile tests on linux clang BUG=105388 ==========
Patchset #2 (id:20001) has been deleted
wychen@chromium.org changed reviewers: + dcheng@chromium.org, thakis@chromium.org
Since the fix https://codereview.chromium.org/2600443003/ is landed, we can enable it again. Hopefully it sticks this time.
The CQ bit was checked by wychen@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by wychen@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by thakis@chromium.org
lgtm
The CQ bit was unchecked by commit-bot@chromium.org
This CL has an open dependency (Issue 2595413004 Patch 1). Please resolve the dependency and try again. If you are sure that there is no real dependency, please use one of the options listed in https://goo.gl/9Es4OR to land the CL.
The CQ bit was checked by wychen@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1483513004070840,
"parent_rev": "3d5689164aa404f926cc961bf9e7e9f78db9235c", "commit_rev":
"bbaa5bd7c5957318f1441e4c1cf4cb0ccb27f1e9"}
Message was sent while issue was closed.
Description was changed from ========== [reland] Enable no-compile tests on linux clang BUG=105388 ========== to ========== [reland] Enable no-compile tests on linux clang BUG=105388 Review-Url: https://codereview.chromium.org/2599243002 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== [reland] Enable no-compile tests on linux clang BUG=105388 Review-Url: https://codereview.chromium.org/2599243002 ========== to ========== [reland] Enable no-compile tests on linux clang BUG=105388 Committed: https://crrev.com/4f7b28c2ea7d46ff26d550e7c16b1a151c213d68 Cr-Commit-Position: refs/heads/master@{#441338} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/4f7b28c2ea7d46ff26d550e7c16b1a151c213d68 Cr-Commit-Position: refs/heads/master@{#441338}
Message was sent while issue was closed.
On 2017/01/04 08:07:31, commit-bot: I haz the power wrote: > Patchset 2 (id:??) landed as > https://crrev.com/4f7b28c2ea7d46ff26d550e7c16b1a151c213d68 > Cr-Commit-Position: refs/heads/master@{#441338} This change broke cross-compile build for Chromium Linux. Cross-compile failure for MIPS can be seen here: http://www.rt-rk.com/mips-buildbot/builders/build_and_test_chromium_trunk_for... Same issue is present when cross-compiling for ARM Linux. //build/nocompile.gni does not set --target option for Clang, which then defaults to x86_64, but --sysroot is set according to target_cpu, and then Clang tries to use appropriate sysroot (in MIPS case it is //build/linux/debian_wheezy_mips-sysroot). This results in mismatch and missing Clang internal include paths which lead to missing header files.
Message was sent while issue was closed.
On 2017/01/10 10:22:14, lmilko wrote: > On 2017/01/04 08:07:31, commit-bot: I haz the power wrote: > > Patchset 2 (id:??) landed as > > https://crrev.com/4f7b28c2ea7d46ff26d550e7c16b1a151c213d68 > > Cr-Commit-Position: refs/heads/master@{#441338} > > This change broke cross-compile build for Chromium Linux. > > Cross-compile failure for MIPS can be seen here: > http://www.rt-rk.com/mips-buildbot/builders/build_and_test_chromium_trunk_for... > > Same issue is present when cross-compiling for ARM Linux. > > //build/nocompile.gni does not set --target option for Clang, which then > defaults to x86_64, but --sysroot is set according to target_cpu, and then Clang > tries to use appropriate sysroot (in MIPS case it is > //build/linux/debian_wheezy_mips-sysroot). This results in mismatch and missing > Clang internal include paths which lead to missing header files. Thanks for reporting this issue. A bug is filed here: https://bugs.chromium.org/p/chromium/issues/detail?id=679699 A tentative solution is here: https://codereview.chromium.org/2623753003/ Would you mind double-checking if this CL fixes the issue? Thanks!
Message was sent while issue was closed.
On 2017/01/10 11:21:38, wychen wrote: > On 2017/01/10 10:22:14, lmilko wrote: > > On 2017/01/04 08:07:31, commit-bot: I haz the power wrote: > > > Patchset 2 (id:??) landed as > > > https://crrev.com/4f7b28c2ea7d46ff26d550e7c16b1a151c213d68 > > > Cr-Commit-Position: refs/heads/master@{#441338} > > > > This change broke cross-compile build for Chromium Linux. > > > > Cross-compile failure for MIPS can be seen here: > > > http://www.rt-rk.com/mips-buildbot/builders/build_and_test_chromium_trunk_for... > > > > Same issue is present when cross-compiling for ARM Linux. > > > > //build/nocompile.gni does not set --target option for Clang, which then > > defaults to x86_64, but --sysroot is set according to target_cpu, and then > Clang > > tries to use appropriate sysroot (in MIPS case it is > > //build/linux/debian_wheezy_mips-sysroot). This results in mismatch and > missing > > Clang internal include paths which lead to missing header files. > > Thanks for reporting this issue. > A bug is filed here: > https://bugs.chromium.org/p/chromium/issues/detail?id=679699 > > A tentative solution is here: https://codereview.chromium.org/2623753003/ > Would you mind double-checking if this CL fixes the issue? Thanks! I checked, with your change MIPS Linux and ARM Linux do not have build issue. Thanks.
Message was sent while issue was closed.
On 2017/01/10 11:54:27, lmilko wrote: > I checked, with your change MIPS Linux and ARM Linux do not have build issue. > Thanks. Awesome! Thanks for your prompt reply. |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
