Do not assume output dir is two levels down in no-compile tests

Do not assume output dir is two levels down in no-compile tests

BUG=676649
Committed: https://crrev.com/58b75f59f1ba2d7c658be97ac0fe04b13c152dd6
Cr-Commit-Position: refs/heads/master@{#440595}

[wychen, 2016-12-23 04:20:46]

wychen@chromium.org changed reviewers:
+ dcheng@chromium.org

[wychen, 2016-12-23 04:20:47]

PTAL

[dcheng, 2016-12-23 05:46:46]

lgtm

(i expect we might have to relax the checks further if we get this working on,
say, win clang)

https://codereview.chromium.org/2600443003/diff/1/base/bind_unittest.nc
File base/bind_unittest.nc (right):

https://codereview.chromium.org/2600443003/diff/1/base/bind_unittest.nc#newco...
base/bind_unittest.nc:206: #elif defined(NCTEST_DISALLOW_CAPTURING_LAMBDA)  //
[r"fatal error: implicit instantiation of undefined template
'base::internal::FunctorTraits<\(lambda at [^
]+/base/bind_unittest.nc:[0-9]+:[0-9]+\), void>'"]
Nit: slightly more precise might be (\.\./)+

[wychen, 2016-12-23 06:55:00]

https://codereview.chromium.org/2600443003/diff/1/base/bind_unittest.nc
File base/bind_unittest.nc (right):

https://codereview.chromium.org/2600443003/diff/1/base/bind_unittest.nc#newco...
base/bind_unittest.nc:206: #elif defined(NCTEST_DISALLOW_CAPTURING_LAMBDA)  //
[r"fatal error: implicit instantiation of undefined template
'base::internal::FunctorTraits<\(lambda at [^
]+/base/bind_unittest.nc:[0-9]+:[0-9]+\), void>'"]
On 2016/12/23 05:46:46, dcheng wrote:
> Nit: slightly more precise might be (\.\./)+

Done.

[wychen, 2016-12-23 06:55:04]

The CQ bit was checked by wychen@chromium.org

[wychen, 2016-12-23 06:55:04]

The patchset sent to the CQ was uploaded after l-g-t-m from dcheng@chromium.org
Link to the patchset: https://codereview.chromium.org/2600443003/#ps20001
(title: "address comment")

[commit-bot: I haz the power, 2016-12-23 06:55:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-23 07:08:46]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1482476104449300,
"parent_rev": "3dd2e3e72c6ae592a169c2442ac5067c1ebc9137", "commit_rev":
"5ea76693482dbce4a1e3230a6c85049dc97baaac"}

[commit-bot: I haz the power, 2016-12-23 07:09:13]

Description was changed from

==========
Do not assume output dir is two levels down in no-compile tests

BUG=676649
==========

to

==========
Do not assume output dir is two levels down in no-compile tests

BUG=676649

Review-Url: https://codereview.chromium.org/2600443003
==========

[commit-bot: I haz the power, 2016-12-23 07:09:14]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-12-23 07:11:19]

Description was changed from

==========
Do not assume output dir is two levels down in no-compile tests

BUG=676649

Review-Url: https://codereview.chromium.org/2600443003
==========

to

==========
Do not assume output dir is two levels down in no-compile tests

BUG=676649

Committed: https://crrev.com/58b75f59f1ba2d7c658be97ac0fe04b13c152dd6
Cr-Commit-Position: refs/heads/master@{#440595}
==========

[commit-bot: I haz the power, 2016-12-23 07:11:20]

Patchset 2 (id:??) landed as
https://crrev.com/58b75f59f1ba2d7c658be97ac0fe04b13c152dd6
Cr-Commit-Position: refs/heads/master@{#440595}