Include-what-you-use for WrapUnique/MakeUnique.

Include-what-you-use for WrapUnique/MakeUnique.

This CL adds #include "base/memory/ptr_util.h" to any .h/.cc/.cpp/.mm
file that contains the string "base::MakeUnique" or "base::WrapUnique"
on a line that doesn't start with "//" and whose corresponding .h file
doesn't already contain the include.

.h files are processed first so that the #include is not added to a
.cc/.cpp/.mm file if it is also added to the corresponding .h file.

tools/sort-headers.py was applied to affected files.

TBR=brettw@chromium.org
BUG=675631
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Committed: https://crrev.com/ba12142132d0e0920acfd23a867a0746846ffc16
Cr-Commit-Position: refs/heads/master@{#440654}

[fdoray, 2016-12-23 14:49:59]

Description was changed from

==========
Include-what-you-use for WrapUnique/MakeUnique.

This CL adds #include "base/memory/ptr_util.h" to any .h/.cc/.cpp/.mm
file that contains the string "base::MakeUnique" or "base::WrapUnique"
on a line that doesn't start with "//" and whose corresponding .h file
doesn't already contain the include.

.h files are processed first so that the #include is not added to a
.cc/.cpp/.mm file if it is also added to the corresponding .h file.

tools/sort-headers.py was applied to affected files.

BUG=675631
==========

to

==========
Include-what-you-use for WrapUnique/MakeUnique.

This CL adds #include "base/memory/ptr_util.h" to any .h/.cc/.cpp/.mm
file that contains the string "base::MakeUnique" or "base::WrapUnique"
on a line that doesn't start with "//" and whose corresponding .h file
doesn't already contain the include.

.h files are processed first so that the #include is not added to a
.cc/.cpp/.mm file if it is also added to the corresponding .h file.

tools/sort-headers.py was applied to affected files.

BUG=675631
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[fdoray, 2016-12-23 14:50:01]

Description was changed from

==========
Include-what-you-use for WrapUnique/MakeUnique.

This CL adds #include "base/memory/ptr_util.h" to any .h/.cc/.cpp/.mm
file that contains the string "base::MakeUnique" or "base::WrapUnique"
on a line that doesn't start with "//" and whose corresponding .h file
doesn't already contain the include.

.h files are processed first so that the #include is not added to a
.cc/.cpp/.mm file if it is also added to the corresponding .h file.

tools/sort-headers.py was applied to affected files.

BUG=675631
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Include-what-you-use for WrapUnique/MakeUnique.

This CL adds #include "base/memory/ptr_util.h" to any .h/.cc/.cpp/.mm
file that contains the string "base::MakeUnique" or "base::WrapUnique"
on a line that doesn't start with "//" and whose corresponding .h file
doesn't already contain the include.

.h files are processed first so that the #include is not added to a
.cc/.cpp/.mm file if it is also added to the corresponding .h file.

tools/sort-headers.py was applied to affected files.

BUG=675631
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[fdoray, 2016-12-23 15:03:03]

The CQ bit was checked by fdoray@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-23 15:03:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[fdoray, 2016-12-23 15:03:19]

fdoray@chromium.org changed reviewers:
+ gab@chromium.org

[fdoray, 2016-12-23 15:03:22]

PTAL

[gab, 2016-12-23 15:42:11]

LGTM w/ comment

https://codereview.chromium.org/2598963005/diff/20001/ui/views/widget/desktop...
File
ui/views/widget/desktop_aura/x11_topmost_window_finder_interactive_uitest.cc
(left):

https://codereview.chromium.org/2598963005/diff/20001/ui/views/widget/desktop...
ui/views/widget/desktop_aura/x11_topmost_window_finder_interactive_uitest.cc:9:
#include <X11/extensions/shape.h>
Not sure why those were sorted this way but I'd err on the side of let's not
bother changing it just in case it mattered

[commit-bot: I haz the power, 2016-12-23 17:05:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-23 17:05:11]

Dry run: This issue passed the CQ dry run.

[fdoray, 2016-12-23 17:33:46]

The CQ bit was checked by fdoray@chromium.org

[fdoray, 2016-12-23 17:33:48]

The patchset sent to the CQ was uploaded after l-g-t-m from gab@chromium.org
Link to the patchset: https://codereview.chromium.org/2598963005/#ps40001
(title: "restore order of includes in
x11_topmost_window_finder_interactive_uitest.cc")

[commit-bot: I haz the power, 2016-12-23 17:34:08]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[fdoray, 2016-12-23 17:34:08]

https://codereview.chromium.org/2598963005/diff/20001/ui/views/widget/desktop...
File
ui/views/widget/desktop_aura/x11_topmost_window_finder_interactive_uitest.cc
(left):

https://codereview.chromium.org/2598963005/diff/20001/ui/views/widget/desktop...
ui/views/widget/desktop_aura/x11_topmost_window_finder_interactive_uitest.cc:9:
#include <X11/extensions/shape.h>
On 2016/12/23 15:42:11, gab (HOHOHO) wrote:
> Not sure why those were sorted this way but I'd err on the side of let's not
> bother changing it just in case it mattered

Done.

[fdoray, 2016-12-23 17:46:22]

The CQ bit was unchecked by fdoray@chromium.org

[fdoray, 2016-12-23 17:46:40]

fdoray@chromium.org changed reviewers:
+ brettw@chromium.org

[fdoray, 2016-12-23 17:47:10]

Description was changed from

==========
Include-what-you-use for WrapUnique/MakeUnique.

This CL adds #include "base/memory/ptr_util.h" to any .h/.cc/.cpp/.mm
file that contains the string "base::MakeUnique" or "base::WrapUnique"
on a line that doesn't start with "//" and whose corresponding .h file
doesn't already contain the include.

.h files are processed first so that the #include is not added to a
.cc/.cpp/.mm file if it is also added to the corresponding .h file.

tools/sort-headers.py was applied to affected files.

BUG=675631
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
Include-what-you-use for WrapUnique/MakeUnique.

This CL adds #include "base/memory/ptr_util.h" to any .h/.cc/.cpp/.mm
file that contains the string "base::MakeUnique" or "base::WrapUnique"
on a line that doesn't start with "//" and whose corresponding .h file
doesn't already contain the include.

.h files are processed first so that the #include is not added to a
.cc/.cpp/.mm file if it is also added to the corresponding .h file.

tools/sort-headers.py was applied to affected files.

TBR=brettw@chromium.org
BUG=675631
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[fdoray, 2016-12-23 17:47:23]

The CQ bit was checked by fdoray@chromium.org

[commit-bot: I haz the power, 2016-12-23 17:47:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-23 19:51:54]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1482515243778190,
"parent_rev": "35c939d0def312159a1b6f4249fb969110792af0", "commit_rev":
"43e7b29966d35c02a9301257f626569385dc7428"}

[commit-bot: I haz the power, 2016-12-23 19:52:25]

Description was changed from

==========
Include-what-you-use for WrapUnique/MakeUnique.

This CL adds #include "base/memory/ptr_util.h" to any .h/.cc/.cpp/.mm
file that contains the string "base::MakeUnique" or "base::WrapUnique"
on a line that doesn't start with "//" and whose corresponding .h file
doesn't already contain the include.

.h files are processed first so that the #include is not added to a
.cc/.cpp/.mm file if it is also added to the corresponding .h file.

tools/sort-headers.py was applied to affected files.

TBR=brettw@chromium.org
BUG=675631
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
Include-what-you-use for WrapUnique/MakeUnique.

This CL adds #include "base/memory/ptr_util.h" to any .h/.cc/.cpp/.mm
file that contains the string "base::MakeUnique" or "base::WrapUnique"
on a line that doesn't start with "//" and whose corresponding .h file
doesn't already contain the include.

.h files are processed first so that the #include is not added to a
.cc/.cpp/.mm file if it is also added to the corresponding .h file.

tools/sort-headers.py was applied to affected files.

TBR=brettw@chromium.org
BUG=675631
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2598963005
==========

[commit-bot: I haz the power, 2016-12-23 19:52:30]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-12-23 19:54:38]

Description was changed from

==========
Include-what-you-use for WrapUnique/MakeUnique.

This CL adds #include "base/memory/ptr_util.h" to any .h/.cc/.cpp/.mm
file that contains the string "base::MakeUnique" or "base::WrapUnique"
on a line that doesn't start with "//" and whose corresponding .h file
doesn't already contain the include.

.h files are processed first so that the #include is not added to a
.cc/.cpp/.mm file if it is also added to the corresponding .h file.

tools/sort-headers.py was applied to affected files.

TBR=brettw@chromium.org
BUG=675631
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2598963005
==========

to

==========
Include-what-you-use for WrapUnique/MakeUnique.

This CL adds #include "base/memory/ptr_util.h" to any .h/.cc/.cpp/.mm
file that contains the string "base::MakeUnique" or "base::WrapUnique"
on a line that doesn't start with "//" and whose corresponding .h file
doesn't already contain the include.

.h files are processed first so that the #include is not added to a
.cc/.cpp/.mm file if it is also added to the corresponding .h file.

tools/sort-headers.py was applied to affected files.

TBR=brettw@chromium.org
BUG=675631
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Committed: https://crrev.com/ba12142132d0e0920acfd23a867a0746846ffc16
Cr-Commit-Position: refs/heads/master@{#440654}
==========

[commit-bot: I haz the power, 2016-12-23 19:54:43]

Patchset 3 (id:??) landed as
https://crrev.com/ba12142132d0e0920acfd23a867a0746846ffc16
Cr-Commit-Position: refs/heads/master@{#440654}