cmdline flags override analysis options in file

cmdline flags override analysis options in file

Update command line arguments processing so that any analysis options
flags specified on the command line (e.g. --supermixin) take precedence
over corresponding flags in the analysis_options.yaml file.

R=brianwilkerson@google.com

Committed: https://github.com/dart-lang/sdk/commit/0863ac0b2cf80460d3de770d2ed1281a2b658fd8

[danrubel, 2016-12-21 20:42:36]

danrubel@google.com changed reviewers:
+ brianwilkerson@google.com

[Brian Wilkerson, 2016-12-21 21:48:06]

lgtm

https://codereview.chromium.org/2598523003/diff/20001/pkg/analyzer/lib/src/co...
File pkg/analyzer/lib/src/command_line/arguments.dart (right):

https://codereview.chromium.org/2598523003/diff/20001/pkg/analyzer/lib/src/co...
pkg/analyzer/lib/src/command_line/arguments.dart:32: * Update [options] with the
value of each analysis option command line flag,
"," --> "."

https://codereview.chromium.org/2598523003/diff/20001/pkg/analyzer/lib/src/co...
pkg/analyzer/lib/src/command_line/arguments.dart:34: void
applyAnalysisOptionFlags(AnalysisOptions options, ArgResults args) {
Something to consider: The only call site I see is in ContextBuilder, where we
already know that the first argument is an AnalysisOptionsImpl. If we change the
type to the subclass then we could remove a lot of casts...

[danrubel, 2016-12-23 01:32:04]

https://codereview.chromium.org/2598523003/diff/20001/pkg/analyzer/lib/src/co...
File pkg/analyzer/lib/src/command_line/arguments.dart (right):

https://codereview.chromium.org/2598523003/diff/20001/pkg/analyzer/lib/src/co...
pkg/analyzer/lib/src/command_line/arguments.dart:32: * Update [options] with the
value of each analysis option command line flag,
On 2016/12/21 21:48:06, Brian Wilkerson wrote:
> "," --> "."

Done.

https://codereview.chromium.org/2598523003/diff/20001/pkg/analyzer/lib/src/co...
pkg/analyzer/lib/src/command_line/arguments.dart:34: void
applyAnalysisOptionFlags(AnalysisOptions options, ArgResults args) {
On 2016/12/21 21:48:06, Brian Wilkerson wrote:
> Something to consider: The only call site I see is in ContextBuilder, where we
> already know that the first argument is an AnalysisOptionsImpl. If we change
the
> type to the subclass then we could remove a lot of casts...

Good point. Done.

[danrubel, 2016-12-23 01:36:10]

Description was changed from

==========
cmdline flags override analysis options in file

Update command line arguments processing so that any analysis options
flags specified on the command line (e.g. --supermixin) take precedence
over corresponding flags in the analysis_options.yaml file.
==========

to

==========
cmdline flags override analysis options in file

Update command line arguments processing so that any analysis options
flags specified on the command line (e.g. --supermixin) take precedence
over corresponding flags in the analysis_options.yaml file.

R=brianwilkerson@google.com

Committed:
https://github.com/dart-lang/sdk/commit/0863ac0b2cf80460d3de770d2ed1281a2b658fd8
==========

[danrubel, 2016-12-23 01:36:11]

Committed patchset #4 (id:60001) manually as
0863ac0b2cf80460d3de770d2ed1281a2b658fd8 (presubmit successful).