cmdline flags override analysis options in file

pkg/analyzer/lib/src/command_line/arguments.dart

 // Copyright (c) 2016, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library analyzer.src.command_line.arguments;
 
 import 'dart:collection';
 
 import 'package:analyzer/file_system/file_system.dart';
 import 'package:analyzer/src/context/builder.dart';
 import 'package:analyzer/src/dart/sdk/sdk.dart';
 import 'package:analyzer/src/generated/engine.dart';
 import 'package:analyzer/src/generated/sdk.dart';
 import 'package:args/args.dart';
 import 'package:path/path.dart';
 
 const String analysisOptionsFileOption = 'options';
 const String defineVariableOption = 'D';
 const String enableInitializingFormalAccessFlag = 'initializing-formal-access';
 const String enableStrictCallChecksFlag = 'enable-strict-call-checks';
-const String enableSuperInMixinFlag = 'supermixin';
+const String enableSuperMixinFlag = 'supermixin';
 const String ignoreUnrecognizedFlagsFlag = 'ignore-unrecognized-flags';
 const String noImplicitCastsFlag = 'no-implicit-casts';
 const String noImplicitDynamicFlag = 'no-implicit-dynamic';
 const String packageRootOption = 'package-root';
 const String packagesOption = 'packages';
 const String sdkPathOption = 'dart-sdk';
 const String sdkSummaryPathOption = 'dart-sdk-summary';
 const String strongModeFlag = 'strong';
 
 /**
+ * Update [options] with the value of each analysis option command line flag,

[Brian Wilkerson, 2016/12/21 21:48:06]

"," --> "."

[danrubel, 2016/12/23 01:32:03]

Done.

+ */
+void applyAnalysisOptionFlags(AnalysisOptions options, ArgResults args) {

[Brian Wilkerson, 2016/12/21 21:48:06]

Something to consider: The only call site I see is in ContextBuilder, where we
already know that the first argument is an AnalysisOptionsImpl. If we change the
type to the subclass then we could remove a lot of casts...

[danrubel, 2016/12/23 01:32:03]

Good point. Done.

+  if (args.wasParsed(enableStrictCallChecksFlag)) {
+    (options as AnalysisOptionsImpl).enableStrictCallChecks =
+        args[enableStrictCallChecksFlag];
+  }
+  if (args.wasParsed(enableSuperMixinFlag)) {
+    (options as AnalysisOptionsImpl).enableSuperMixins =
+        args[enableSuperMixinFlag];
+  }
+  if (args.wasParsed(noImplicitCastsFlag)) {
+    (options as AnalysisOptionsImpl).implicitCasts = !args[noImplicitCastsFlag];
+  }
+  if (args.wasParsed(noImplicitDynamicFlag)) {
+    (options as AnalysisOptionsImpl).implicitDynamic =
+        !args[noImplicitDynamicFlag];
+  }
+  if (args.wasParsed(strongModeFlag)) {
+    (options as AnalysisOptionsImpl).strongMode = args[strongModeFlag];
+  }
+}
+
+/**
  * Use the given [resourceProvider], [contentCache] and command-line [args] to
  * create a context builder.
  */
 ContextBuilderOptions createContextBuilderOptions(ArgResults args) {
   ContextBuilderOptions builderOptions = new ContextBuilderOptions();
+  builderOptions.argResults = args;
   //
   // File locations.
   //
   builderOptions.dartSdkSummaryPath = args[sdkSummaryPathOption];
   builderOptions.defaultAnalysisOptionsFilePath =
       args[analysisOptionsFileOption];
   builderOptions.defaultPackageFilePath = args[packagesOption];
   builderOptions.defaultPackagesDirectoryPath = args[packageRootOption];
   //
   // Analysis options.
   //
   AnalysisOptionsImpl defaultOptions = new AnalysisOptionsImpl();
-  defaultOptions.enableStrictCallChecks = args[enableStrictCallChecksFlag];
-  defaultOptions.enableSuperMixins = args[enableSuperInMixinFlag];
-  defaultOptions.implicitCasts = !args[noImplicitCastsFlag];
-  defaultOptions.implicitDynamic = !args[noImplicitDynamicFlag];
-  defaultOptions.strongMode = args[strongModeFlag];
+  applyAnalysisOptionFlags(defaultOptions, args);
   builderOptions.defaultOptions = defaultOptions;
   //
   // Declared variables.
   //
   Map<String, String> declaredVariables = <String, String>{};
   List<String> variables = args[defineVariableOption] as List<String>;
   for (String variable in variables) {
     int index = variable.indexOf('=');
     if (index < 0) {
       // TODO (brianwilkerson) Decide the semantics we want in this case.
@@ skipping 92 matching lines @@
       defaultsTo: false,
       negatable: false,
       hide: hide || ddc);
   parser.addFlag(enableInitializingFormalAccessFlag,
       help:
           'Enable support for allowing access to field formal parameters in a '
           'constructor\'s initializer list',
       defaultsTo: false,
       negatable: false,
       hide: hide || ddc);
-  parser.addFlag(enableSuperInMixinFlag,
+  parser.addFlag(enableSuperMixinFlag,
       help: 'Relax restrictions on mixins (DEP 34).',
       defaultsTo: false,
       negatable: false,
       hide: hide || ddc);
 //  parser.addFlag('enable_type_checks',
 //      help: 'Check types in constant evaluation.',
 //      defaultsTo: false,
 //      negatable: false,
 //      hide: hide || ddc);
 }
@@ skipping 116 matching lines @@
           .replaceAll('\r\n', '\n')
           .replaceAll('\r', '\n')
           .split('\n')
           .where((String line) => line.isNotEmpty));
     } on FileSystemException catch (e) {
       throw new Exception('Failed to read file specified by $lastArg : $e');
     }
   }
   return args;
 }