cmdline flags override analysis options in file

pkg/analyzer/lib/src/context/builder.dart

 // Copyright (c) 2016, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library analyzer.src.context.context_builder;
 
 import 'dart:collection';
 import 'dart:core';
 
 import 'package:analyzer/context/declared_variables.dart';
 import 'package:analyzer/file_system/file_system.dart';
 import 'package:analyzer/plugin/resolver_provider.dart';
 import 'package:analyzer/source/analysis_options_provider.dart';
 import 'package:analyzer/source/package_map_resolver.dart';
+import 'package:analyzer/src/command_line/arguments.dart'
+    show applyAnalysisOptionFlags;
 import 'package:analyzer/src/dart/sdk/sdk.dart';
 import 'package:analyzer/src/generated/bazel.dart';
 import 'package:analyzer/src/generated/engine.dart';
 import 'package:analyzer/src/generated/sdk.dart';
 import 'package:analyzer/src/generated/source.dart';
 import 'package:analyzer/src/summary/package_bundle_reader.dart';
 import 'package:analyzer/src/summary/pub_summary.dart';
 import 'package:analyzer/src/summary/summary_sdk.dart';
 import 'package:analyzer/src/task/options.dart';
+import 'package:args/args.dart';
 import 'package:package_config/packages.dart';
 import 'package:package_config/packages_file.dart';
 import 'package:package_config/src/packages_impl.dart';
 import 'package:path/src/context.dart';
 import 'package:yaml/yaml.dart';
 
 /**
  * A utility class used to build an analysis context for a given directory.
  *
  * The construction of analysis contexts is as follows:
@@ skipping 308 matching lines @@
       SourceFactory sourceFactory =
           new SourceFactory(resolvers, packages, resourceProvider);
       try {
         Map<String, YamlNode> optionMap =
             new AnalysisOptionsProvider(sourceFactory)
                 .getOptionsFromFile(optionsFile);
         applyToAnalysisOptions(options, optionMap);
       } catch (_) {
         // Ignore exceptions thrown while trying to load the options file.
       }
+      if (builderOptions.argResults != null) {
+        applyAnalysisOptionFlags(options, builderOptions.argResults);
+      }
     }
     return options;
   }
 
   /**
    * Return the analysis options file that should be used when analyzing code in
    * the directory with the given [path].
    */
   File getOptionsFile(String path) {
     String filePath = builderOptions.defaultAnalysisOptionsFilePath;
@@ skipping 112 matching lines @@
     }
     return null;
   }
 }
 
 /**
  * Options used by a [ContextBuilder].
  */
 class ContextBuilderOptions {
   /**
+   * The results of parsing the command line arguments as defined by
+   * [defineAnalysisArguments] or `null` if none.
+   */
+  ArgResults argResults;
+
+  /**
    * The file path of the file containing the summary of the SDK that should be
    * used to "analyze" the SDK. This option should only be specified by
    * command-line tools such as 'dartanalyzer' or 'ddc'.
    */
   String dartSdkSummaryPath;
 
   /**
    * The file path of the analysis options file that should be used in place of
    * any file in the root directory or a parent of the root directory, or `null`
    * if the normal lookup mechanism should be used.
@@ skipping 125 matching lines @@
   String _readEmbedderYaml(Folder libDir) {
     File file = libDir.getChild(EMBEDDER_FILE_NAME);
     try {
       return file.readAsStringSync();
     } on FileSystemException {
       // File can't be read.
       return null;
     }
   }
 }