pkg/analyzer/lib/src/task/options.dart - Issue 2598523003: cmdline flags override analysis options in file

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analyzer/lib/src/task/options.dart

Issue 2598523003: cmdline flags override analysis options in file (Closed)

Patch Set: address comments Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/analyzer/lib/src/task/options.dart

diff --git a/pkg/analyzer/lib/src/task/options.dart b/pkg/analyzer/lib/src/task/options.dart

index 6995b2af3f37d9c8045f0fb3e76c748bff32b12a..050d3bce27f8843cf8cde03cf5f6bde82a5fa1f5 100644

--- a/pkg/analyzer/lib/src/task/options.dart

+++ b/pkg/analyzer/lib/src/task/options.dart

@@ -538,7 +538,7 @@ class _OptionsProcessor {

if (feature == AnalyzerOptions.enableAssertInitializer) {

options.enableAssertInitializer = boolValue;

} else if (feature == AnalyzerOptions.enableStrictCallChecks) {

- options.enableStrictCallChecks = true;

+ options.enableStrictCallChecks = boolValue;

} else if (feature == AnalyzerOptions.enableSuperMixins) {

options.enableSuperMixins = boolValue;

}